-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor type generation scripts #2379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult `ts` compiler host. This ensures that no filesystem operations are attempted by typescript.
…e right place), and ensure no `declare`s inside `module` declarations
jasnell
reviewed
Jul 11, 2024
jasnell
reviewed
Jul 11, 2024
jasnell
reviewed
Jul 11, 2024
jasnell
reviewed
Jul 11, 2024
jasnell
approved these changes
Jul 11, 2024
andyjessop
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! One tiny comment, but the overall approach and implementation looks absolutely fine 👍
ns476
pushed a commit
to ns476/workerd
that referenced
this pull request
Aug 2, 2024
* Create a fully in-memory compiler host, rather than patching the default `ts` compiler host. This ensures that no filesystem operations are attempted by typescript. * [new] support additional lib files when constructing an in-memory TS program * Refactor modifier checking (ensuring `export` and `declare` are in the right place), and ensure no `declare`s inside `module` declarations * Use new in-memory types for overrides and defines * Refactor global extraction * More refactoring * Fix tests and add updates * Address comments * Remove unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of landing Types as a Service.
This is a relatively large PR, but it's pretty low risk. It mostly contains some refactoring of the type generation code (e.g. files like types/src/transforms/overrides/compiler.ts which have not changed in functionality). In large part this refactoring is to make it easier for a future PR (another part of #1959) to run this code in a Worker (for instance, changing
import ... from "assert"
toimport ... from "node:assert"
is in support of this goal, as well as the enhancing of the memory-based compiler host we use for running TypeScript).This PR changes the output of the generated
index.d.ts
files to no longerdeclare
things for which that's not necessary. This is semantically the same thing, and should have no impact on the usage of these types. We probably should've done it like this all along:However, this has resulted in some test changes—the behaviour is otherwise unchanged, and the output after this PR should be the same as the output before.
This PR doesn't cover:
cloudflare:sockets
is still defined by hand, although this PR does add some additional mechanics to make this possible in future.@cloudflare/workers-types
with a Worker #2405@cloudflare/workers-types
package in CI@cloudflare/workers-types
with a Worker #2405To aid reviewing, this link shows the diff between
@cloudflare/workers-types@4.20240701.0
and the output of the type generation scripts run from this branch.