[types] Generate @cloudflare/workers-types with a Worker
#2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penalosa
changed the title
penalosa
changed the title
@cloudflare/workers-types with a Worker
3 tasks
jasnell
reviewed
Jul 17, 2024
jasnell
approved these changes
Jul 17, 2024
DaniFoldi
reviewed
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing to land #1959 piecemeal. This will probably be the final part we land.
This PR does not change the type generation output, which is identical before and after this PR.
The primary purpose is to add a Worker which does type generation using the
workerd:rttimodule. That worker is typed under it's own output. This works because we useesbuildto build the Worker, which only does type-stripping.Because we now have a Worker to generate types, we use that in CI to construct the
@cloudflare/workers-typespackage, removing much of the old code for doing that. Of note: this PR also disables dealing with internal modules (cloudflare-internal:email), and turns off type generation for modules likecloudflare:email(relying on the existing manually written types). This is because the type definitions included bothcloudflare-internal:emailandcloudflare:email, which led to a fairly confusing user experience when consuming the types. This is something we should figure out a better forward on.