Use bazel to manage clang-format #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npaun
requested review from
harrishancock,
ObsidianMinor,
fhanau and
danlapid
and removed request for
harrishancock and
ObsidianMinor
anonrig
reviewed
Sep 24, 2024
| name = "clang-format-linux-arm64", | ||
| executable = True, | ||
| integrity = "sha256-iCbaPg60x60eA9ZIWmSdFva/RD9xOBcJLUwSRK8Gxzk=", | ||
| url = "https://github.com/npaun/bins/releases/download/llvm-18.1.8/llvm-18.1.8-linux-arm64-clang-format", |
There was a problem hiding this comment.
Can we move this to a repository inside Cloudflare organization?
There was a problem hiding this comment.
This can be merged and we can move it to a CF org repo later, it'll involve some tickets and stuff and shouldn't block enabling formatting again.
There was a problem hiding this comment.
A comment in here explaining that would be helpful
danlapid
approved these changes
Sep 24, 2024
jasnell
approved these changes
Sep 24, 2024
npaun
force-pushed
the
npaun/clang-format-bazel
branch
from
ef8649c
to
c904c11
Compare
npaun
force-pushed
the
npaun/clang-format-bazel
branch
from
c904c11
to
f4b6317
Compare
jclee
pushed a commit
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.