Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix invalid this errors on node:buffer #2907

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix invalid this errors on node:buffer #2907

merged 1 commit into from
Oct 11, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Oct 11, 2024 •
edited
Loading

@anonrig anonrig requested a review from jasnell October 11, 2024 13:41
@anonrig anonrig requested review from a team as code owners October 11, 2024 13:41
@anonrig anonrig requested a review from danlapid October 11, 2024 13:41
@anonrig anonrig mentioned this pull request Oct 11, 2024
Closed
@anonrig anonrig force-pushed the yagiz/fix-invalid-this-buffer branch from 820cc96 to 19f52a7 Compare October 11, 2024 13:44
@anonrig anonrig merged commit 4edac49 into main Oct 11, 2024
13 checks passed
@anonrig anonrig deleted the yagiz/fix-invalid-this-buffer branch October 11, 2024 14:27
vicb
vicb reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I forgot to publish this comment

src/workerd/api/node/tests/node-compat-v2-test.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicb vicb vicb left review comments

@jasnell jasnell jasnell approved these changes

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@danlapid danlapid Awaiting requested review from danlapid danlapid is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anonrig @petebacondarwin @vicb @jasnell