Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor(node/buffer): update cloudflare hybrid exports (#321)" #324

Closed
wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Oct 11, 2024

The tests are actually failing

workerd/server/server.c++:3851: debug: [ TEST ] tests:buffer_implements
[server] unenv/runtime/node/buffer from /tests
workerd/io/worker.c++:2065: info: uncaught exception; source = Uncaught (in promise); stack = TypeError: Failed to execute 'isAscii' on 'BufferUtil': parameter 1 is not of type 'ArrayBuffer or ArrayBufferView'.
    at Module.isAscii (node-internal:internal_buffer:1763:23)
    at Object.test (tests:39:22)
workerd/util/symbolizer.c++:158: warning: llvm-symbolizer was not found. To symbolize stack traces, install it in your $PATH or set $LLVM_SYMBOLIZER to the location of the binary. When running tests under bazel, use `--test_env=LLVM_SYMBOLIZER=<path>`.
workerd/io/io-context.c++:352: info: uncaught exception; exception = workerd/jsg/_virtual_includes/jsg/workerd/jsg/value.h:1372: failed: jsg.TypeError: Failed to execute 'isAscii' on 'BufferUtil': parameter 1 is not of type 'ArrayBuffer or ArrayBufferView'.
workerd/server/server.c++:3859: debug: [ FAIL ] tests:buffer_implements

The CI also needs to be fixed to reflect that

/cc @anonrig

@vicb vicb requested review from a team and pi0 as code owners October 11, 2024 06:08
@anonrig
Copy link
Contributor

anonrig commented Oct 11, 2024

I opened a PR to fix the test: #325

@anonrig
Copy link
Contributor

anonrig commented Oct 11, 2024

It seems we have a bug on the runtime. Ref: cloudflare/workerd#2907

We can land this and once that fix is released, I can open a new pull-request.

@vicb
Copy link
Contributor Author

vicb commented Oct 11, 2024

unneeded after #325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants