Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI does not catch workerd test failures #327

Closed
vicb opened this issue Oct 11, 2024 · 0 comments · Fixed by #333
Closed

CI does not catch workerd test failures #327

vicb opened this issue Oct 11, 2024 · 0 comments · Fixed by #333
Labels
bug Something isn't working

Comments

@vicb
Copy link
Contributor

vicb commented Oct 11, 2024

Environment

CI

Reproduction

See

Describe the bug

The workerd tests fails - see the linked PR for more info but the CI is green

Additional context

Logs

workerd/server/server.c++:3851: debug: [ TEST ] tests:buffer_implements
[server] unenv/runtime/node/buffer from /tests
workerd/io/worker.c++:2065: info: uncaught exception; source = Uncaught (in promise); stack = TypeError: Failed to execute 'isAscii' on 'BufferUtil': parameter 1 is not of type 'ArrayBuffer or ArrayBufferView'.
    at Module.isAscii (node-internal:internal_buffer:1763:23)
    at Object.test (tests:39:22)
workerd/util/symbolizer.c++:158: warning: llvm-symbolizer was not found. To symbolize stack traces, install it in your $PATH or set $LLVM_SYMBOLIZER to the location of the binary. When running tests under bazel, use `--test_env=LLVM_SYMBOLIZER=<path>`.
workerd/io/io-context.c++:352: info: uncaught exception; exception = workerd/jsg/_virtual_includes/jsg/workerd/jsg/value.h:1372: failed: jsg.TypeError: Failed to execute 'isAscii' on 'BufferUtil': parameter 1 is not of type 'ArrayBuffer or ArrayBufferView'.
workerd/server/server.c++:3859: debug: [ FAIL ] tests:buffer_implements
@vicb vicb added the bug Something isn't working label Oct 11, 2024
vicb added a commit that referenced this issue Oct 14, 2024
@pi0 pi0 closed this as completed in #333 Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant