Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fail CI with failed workerd tests #333

Merged
merged 1 commit into from
Oct 15, 2024
Merged

test: fail CI with failed workerd tests #333

merged 1 commit into from
Oct 15, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Oct 14, 2024 •
edited
Loading

Fixes #327

Note: I tested this PR by pushing a failing test, it works fine (and then forced pushed to remove the failing test).

@vicb vicb requested a review from pi0 as a code owner October 14, 2024 13:01
@vicb vicb changed the title Workerd/test fix(cloudflare): CI reports workerd test failures Oct 14, 2024
pi0
pi0 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnx

@pi0 pi0 changed the title fix(cloudflare): CI reports workerd test failures test: fail CI with failed workerd tests Oct 15, 2024
@pi0 pi0 merged commit 2186bfc into main Oct 15, 2024
2 checks passed
@pi0 pi0 deleted the workerd/test branch October 15, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@anonrig anonrig anonrig approved these changes

@petebacondarwin petebacondarwin Awaiting requested review from petebacondarwin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI does not catch workerd test failures
3 participants
@vicb @anonrig @pi0