Update compat date for cache: no-store. #3011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Oct 27, 2024
AdityaAtulTewari
deleted the
AdityaAtulTewari/update-no-store-compat-date
branch
kentonv
reviewed
Oct 27, 2024
| @@ -547,8 +547,8 @@ struct CompatibilityFlags @0x8f8c1b68151b6cef { | |||
| cacheOptionEnabled @53 :Bool | |||
| $compatEnableFlag("cache_option_enabled") | |||
| $compatDisableFlag("cache_option_disabled") | |||
| $experimental; | |||
| # Enables the use of no-cache and no-store headers from requests | |||
| $impliedByAfterDate(name = "cacheOptionEnabled", date = "2024-11-11"); | |||
There was a problem hiding this comment.
This seems to declare that cacheOptionEnabled implies itself. What does that mean?
AFAICT this doesn't do anything, it's basically saying: "After 2024-11-11, whenever cacheOptionEnabled is enabled, then cacheOptionEnabled should be enabled." But that's a tautology.
Did you mean to set $compatEnableDate instead?
There was a problem hiding this comment.
yes: #3014, my mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.