Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compat date for cache: no-store. #3011

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Update compat date for cache: no-store. #3011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/workerd/io/compatibility-date.capnp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,8 +547,8 @@ struct CompatibilityFlags @0x8f8c1b68151b6cef {
cacheOptionEnabled @53 :Bool
$compatEnableFlag("cache_option_enabled")
$compatDisableFlag("cache_option_disabled")
$experimental;
# Enables the use of no-cache and no-store headers from requests
$impliedByAfterDate(name = "cacheOptionEnabled", date = "2024-11-11");
Copy link
Member

@kentonv kentonv Oct 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to declare that cacheOptionEnabled implies itself. What does that mean?

AFAICT this doesn't do anything, it's basically saying: "After 2024-11-11, whenever cacheOptionEnabled is enabled, then cacheOptionEnabled should be enabled." But that's a tautology.

Did you mean to set $compatEnableDate instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes: #3014, my mistake.

# Enables the use of no-store headers from requests

kvDirectBinding @54 :Bool
$compatEnableFlag("kv_direct_binding")
Expand Down