-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 BUG: pages dev output is unnecessarily verbose #4265
Comments
I can confirm this and it's still like that in
There are just way too many warnings for a successful operation
I think a one liner log message for the successful start of the local server would be sufficient. Something like:
or if you want to to be slightly more verbose:
|
) * [wranger] fix: createMetadataObject to use logging levels (#4265) * Update .changeset/wet-lemons-wash.md Update changeset to be more user focussed Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com> --------- Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
It gets worse if you use something like Vite, then you see thousands of urls on every request to the dev servers and can't catch any of our own console.logs anymore |
triaging this as part of https://github.com/cloudflare/workers-sdk/milestone/10 and will discuss with the team if this is something we can take on as part of that body of work |
I'm with @newsve , can we silence the request log messages? I only want to see what I'm logging. Or perhaps a |
Hi folks, First of all, thank you for raising this issue, and for providing us will the information you did <3! As we are picking this up as part of https://github.com/cloudflare/workers-sdk/milestone/10, I just want to confirm the current state of affairs, as codebase has evolved since this issue was first reported. Running
currently outputs the following (pls correct me in case I missed anything): ![]() In the original report by @Cherry, the suggested actionable items were:
Subsequent reports also suggested to
In addition to what was already suggested in these discussions, I'm wondering if logs such as:
are helpful or become noise? Do you have any input on that? |
Personally, I think most of my original issues with the verbosity of this have since been resolved. The compatibility date warning is a bit noisy when you don't specify one (and should maybe recommend And then the "Compiling worker" line is a little verbose and unnecessary, but everything else is useful information now I think. |
I abs agree with you @Cherry that compat date and fns compilation output is noisy. I'll add fixes for both, plus some extra things to make the output more readable and more organised and circle back here. IMHO, our stdout formatting in general could use some more structure and consistency, but not sure if there was ever time to properly address this. I'll see if there's smth we can do abt that as well, but that's for later. In the meanwhile anyone interested in the changes related to this issue can follow the progress over at #5927 |
Currently, the compatibility-date related warning in `pages dev` is noisy and hard to follow. This commit cleans that up and gives it a more structured feel. Fixes #4265
When running `wrangler dev` or `wrangler pages dev`, the wrangler banner is not consistently displayed at the top. For `wrangler pages dev` specifically, which calls `unstable_dev` under the hood, and thus deferring the banner printing to this API, the banner ends up getting lost inbetween other pages-specific logs/warnings, making the whole `pages dev` output vibe random at best. This commit ensures we always display the banner at the top when in dev mode, by: - delegating the banner printing to `pages dev` directly - moving calling `printWranglerBanner()` fn first thing in both wrangler/pages dev handlers - providing a mechanism in the `unstable_dev` API that makes the banner printing at that level optional Fixes #4265
When running `pages dev` in a project with `_headers` and `_redirects` files, we currently display a series of warnings if any invalid headers/redirects rules are found. These warnings are quite noisy, and not cleanly organised, thus making the whole `pages dev` output noisy. This commit cleans up the aforementioned warnings, re-groups and re-organisez them into more readable/easy to make sense of output. Fixes #4265
This commit changes the verbiage in a `_routes.json` related warning, surfaced in `pages dev` output, to something more meaningful and helpful. Fixes #4265
When running `pages dev` in a Pages Functions project, we output the compiled worker output path to stdout. This path tends to be rather noisy in the grand scheme of `pages dev` stdout things, and not much helpful. This commit moves this log to the `debug` output. Fixes #4265
When running `wrangler dev` or `wrangler pages dev`, the wrangler banner is not consistently displayed at the top. For `wrangler pages dev` specifically, which calls `unstable_dev` under the hood, and thus deferring the banner printing to this API, the banner ends up getting lost inbetween other pages-specific logs/warnings, making the whole `pages dev` output vibe random at best. This commit ensures we always display the banner at the top when in dev mode, by: - delegating the banner printing to `pages dev` directly - moving calling `printWranglerBanner()` fn first thing in both wrangler/pages dev handlers - providing a mechanism in the `unstable_dev` API that makes the banner printing at that level optional Fixes #4265
When running `pages dev` in a project with `_headers` and `_redirects` files, we currently display a series of warnings if any invalid headers/redirects rules are found. These warnings are quite noisy, and not cleanly organised, thus making the whole `pages dev` output noisy. This commit cleans up the aforementioned warnings, re-groups and re-organisez them into more readable/easy to make sense of output. Fixes #4265
This commit changes the verbiage in a `_routes.json` related warning, surfaced in `pages dev` output, to something more meaningful and helpful. Fixes #4265
When running `pages dev` in a Pages Functions project, we output the compiled worker output path to stdout. This path tends to be rather noisy in the grand scheme of `pages dev` stdout things, and not much helpful. This commit moves this log to the `debug` output. Fixes #4265
When running `wrangler dev` or `wrangler pages dev`, the wrangler banner is not consistently displayed at the top. For `wrangler pages dev` specifically, which calls `unstable_dev` under the hood, and thus deferring the banner printing to this API, the banner ends up getting lost inbetween other pages-specific logs/warnings, making the whole `pages dev` output vibe random at best. This commit ensures we always display the banner at the top when in dev mode, by: - delegating the banner printing to `pages dev` directly - moving calling `printWranglerBanner()` fn first thing in both wrangler/pages dev handlers - providing a mechanism in the `unstable_dev` API that makes the banner printing at that level optional Fixes #4265
When running `pages dev` in a project with `_headers` and `_redirects` files, we currently display a series of warnings if any invalid headers/redirects rules are found. These warnings are quite noisy, and not cleanly organised, thus making the whole `pages dev` output noisy. This commit cleans up the aforementioned warnings, re-groups and re-organisez them into more readable/easy to make sense of output. Fixes #4265
This commit changes the verbiage in a `_routes.json` related warning, surfaced in `pages dev` output, to something more meaningful and helpful. Fixes #4265
When running `pages dev` in a Pages Functions project, we output the compiled worker output path to stdout. This path tends to be rather noisy in the grand scheme of `pages dev` stdout things, and not much helpful. This commit moves this log to the `debug` output. Fixes #4265
Currently, the compatibility-date related warning in `pages dev` is noisy and hard to follow. This commit cleans that up and gives it a more structured feel. Fixes #4265
When running `wrangler dev` or `wrangler pages dev`, the wrangler banner is not consistently displayed at the top. For `wrangler pages dev` specifically, which calls `unstable_dev` under the hood, and thus deferring the banner printing to this API, the banner ends up getting lost inbetween other pages-specific logs/warnings, making the whole `pages dev` output vibe random at best. This commit ensures we always display the banner at the top when in dev mode, by: - delegating the banner printing to `pages dev` directly - moving calling `printWranglerBanner()` fn first thing in both wrangler/pages dev handlers - providing a mechanism in the `unstable_dev` API that makes the banner printing at that level optional Fixes #4265
When running `pages dev` in a project with `_headers` and `_redirects` files, we currently display a series of warnings if any invalid headers/redirects rules are found. These warnings are quite noisy, and not cleanly organised, thus making the whole `pages dev` output noisy. This commit cleans up the aforementioned warnings, re-groups and re-organisez them into more readable/easy to make sense of output. Fixes #4265
This commit changes the verbiage in a `_routes.json` related warning, surfaced in `pages dev` output, to something more meaningful and helpful. Fixes #4265
When running `pages dev` in a Pages Functions project, we output the compiled worker output path to stdout. This path tends to be rather noisy in the grand scheme of `pages dev` stdout things, and not much helpful. This commit moves this log to the `debug` output. Fixes #4265
Currently, the compatibility-date related warning in `pages dev` is noisy and hard to follow. This commit cleans that up and gives it a more structured feel. Fixes #4265
When running `wrangler dev` or `wrangler pages dev`, the wrangler banner is not consistently displayed at the top. For `wrangler pages dev` specifically, which calls `unstable_dev` under the hood, and thus deferring the banner printing to this API, the banner ends up getting lost inbetween other pages-specific logs/warnings, making the whole `pages dev` output vibe random at best. This commit ensures we always display the banner at the top when in dev mode, by: - delegating the banner printing to `pages dev` directly - moving calling `printWranglerBanner()` fn first thing in both wrangler/pages dev handlers - providing a mechanism in the `unstable_dev` API that makes the banner printing at that level optional Fixes #4265
When running `pages dev` in a project with `_headers` and `_redirects` files, we currently display a series of warnings if any invalid headers/redirects rules are found. These warnings are quite noisy, and not cleanly organised, thus making the whole `pages dev` output noisy. This commit cleans up the aforementioned warnings, re-groups and re-organisez them into more readable/easy to make sense of output. Fixes #4265
This commit changes the verbiage in a `_routes.json` related warning, surfaced in `pages dev` output, to something more meaningful and helpful. Fixes #4265
When running `pages dev` in a Pages Functions project, we output the compiled worker output path to stdout. This path tends to be rather noisy in the grand scheme of `pages dev` stdout things, and not much helpful. This commit moves this log to the `debug` output. Fixes #4265
When running `pages dev` in a Pages Functions project, we output the compiled worker output path to stdout. This path tends to be rather noisy in the grand scheme of `pages dev` stdout things, and not much helpful. This commit moves this log to the `debug` output. Fixes #4265
Currently, the compatibility-date related warning in `pages dev` is noisy and hard to follow. This commit cleans that up and gives it a more structured feel. Fixes #4265
When running `wrangler dev` or `wrangler pages dev`, the wrangler banner is not consistently displayed at the top. For `wrangler pages dev` specifically, which calls `unstable_dev` under the hood, and thus deferring the banner printing to this API, the banner ends up getting lost inbetween other pages-specific logs/warnings, making the whole `pages dev` output vibe random at best. This commit ensures we always display the banner at the top when in dev mode, by: - delegating the banner printing to `pages dev` directly - moving calling `printWranglerBanner()` fn first thing in both wrangler/pages dev handlers - providing a mechanism in the `unstable_dev` API that makes the banner printing at that level optional Fixes #4265
When running `pages dev` in a project with `_headers` and `_redirects` files, we currently display a series of warnings if any invalid headers/redirects rules are found. These warnings are quite noisy, and not cleanly organised, thus making the whole `pages dev` output noisy. This commit cleans up the aforementioned warnings, re-groups and re-organisez them into more readable/easy to make sense of output. Fixes #4265
This commit changes the verbiage in a `_routes.json` related warning, surfaced in `pages dev` output, to something more meaningful and helpful. Fixes #4265
When running `pages dev` in a Pages Functions project, we output the compiled worker output path to stdout. This path tends to be rather noisy in the grand scheme of `pages dev` stdout things, and not much helpful. This commit moves this log to the `debug` output. Fixes #4265
Which Cloudflare product(s) does this pertain to?
Pages, Wrangler core
What version(s) of the tool(s) are you using?
3.14.0
What version of Node are you using?
18.18.0
What operating system are you using?
Windows
Describe the Bug
When running
npx wrangler pages dev <dir>
, you get a LOT of verbose output:That's a lot of visual noise to try and scan and determine if my command was successful or not.
This is without any
wrangler.toml
in my directory.Actionable things I'd recommend:
--local
warning - pages dev is ONLY local and I didn't even pass this. I suspect it's coming fromunstable_dev
: fix: remove confusing--local
messaging fromwrangler pages dev
#4687The text was updated successfully, but these errors were encountered: