Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump min node version to 16.18 to improve tests flakiness #4266

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

Cherry
Copy link
Contributor

@Cherry Cherry commented Oct 23, 2023

What this PR solves / how to test:

Tests like service-bindings-app are regularly throwing errors like this, causing the test suite to fail in CI.

 FATAL ERROR: v8::FromJust Maybe value is Nothing.
   1: 00007FF7F331815F v8::internal::CodeObjectRegistry::~CodeObjectRegistry+114079
   2: 00007FF7F32A54C6 DSA_meth_get_flags+65542
   3: 00007FF7F32A637D node::OnFatalError+301
   4: 00007FF7F3BC6415 v8::V8::FromJustIsNothing+53
   5: 00007FF7F33419E0 node::UVException+912
   6: 00007FF7F3290E69 v8::base::CPU::has_sse+42185
   7: 00007FF7F337B0D7 uv_timer_stop+1207
   8: 00007FF7F337766B uv_async_send+331
   9: 00007FF7F3376DFC uv_loop_init+1292
  10: 00007FF7F3376F9A uv_run+202
  11: 00007FF7F3345E05 node::SpinEventLoop+309
  12: 00007FF7F31DDEC0 v8::internal::interpreter::BytecodeLabel::bind+35776
  13: 00007FF7F31D9518 v8::internal::interpreter::BytecodeLabel::bind+16920
  14: 00007FF7F336766D uv_poll_stop+557
  15: 00007FF7F4180940 v8::internal::compiler::RepresentationChanger::Uint32OverflowOperatorFor+146416
  16: 00007FFDE0734DE0 BaseThreadInitThunk+16
  17: 00007FFDE0B7ED9B RtlUserThreadStart+43
   ELIFECYCLE  Command failed with exit code 134.

This bumps Node to 16.18 in an attempt to fix this, as per references below . It seems to work well.

References:

Associated docs issue(s)/PR(s):

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@Cherry Cherry requested a review from a team as a code owner October 23, 2023 19:25
@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023

⚠️ No Changeset found

Latest commit: e18022f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6618038004/npm-package-wrangler-4266

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6618038004/npm-package-wrangler-4266

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6618038004/npm-package-wrangler-4266 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6618038004/npm-package-cloudflare-pages-shared-4266

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.14.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20231016.0 3.20231016.0
workerd 1.20231016.0 1.20231016.0
workerd --version 1.20231016.0 2023-10-16

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@Cherry Cherry changed the title [do not merge yet] chore: bump min node version to 16.18 bump min node version to 16.18 to fix tests Oct 23, 2023
@Cherry Cherry changed the title bump min node version to 16.18 to fix tests bump min node version to 16.18 to improve tests flakiness Oct 23, 2023
Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@penalosa penalosa merged commit 6a782ff into cloudflare:main Oct 24, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants