Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump min node version to 16.18 to improve tests flakiness #4266

Merged
merged 1 commit into from
Oct 24, 2023
Merged

bump min node version to 16.18 to improve tests flakiness #4266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/choose-pages-projects.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Install Dependencies
uses: ./.github/actions/install-dependencies
env:
node-version: 16.14
node-version: 16.18

- name: Build
run: pnpm run build
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/codecov-context.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
- uses: pnpm/action-setup@v2
with:
version: 8
- name: Use Node.js 16.14
- name: Use Node.js 16.18
uses: actions/setup-node@v3
with:
node-version: 16.14
node-version: 16.18
cache: "pnpm"

- name: Install workerd Dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/create-pullrequest-prerelease.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
- uses: pnpm/action-setup@v2
with:
version: 8.8.0
- name: Use Node.js 16.14
- name: Use Node.js 16.18
uses: actions/setup-node@v3
with:
node-version: 16.14
node-version: 16.18
cache: "pnpm"

- name: Install workerd Dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/d1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
- uses: pnpm/action-setup@v2
with:
version: 8.8.0
- name: Use Node.js 16.14
- name: Use Node.js 16.18
uses: actions/setup-node@v3
with:
node-version: 16.14
node-version: 16.18
cache: "pnpm"

- name: Install workerd Dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/edge-preview-authenticated-proxy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
- uses: pnpm/action-setup@v2
with:
version: 8.8.0
- name: Use Node.js 16.14
- name: Use Node.js 16.18
uses: actions/setup-node@v3
with:
node-version: 16.14
node-version: 16.18
cache: "pnpm"

- name: Install workerd Dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/experimental-wasm-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
- uses: pnpm/action-setup@v2
with:
version: 8.8.0
- name: Use Node.js 16.14
- name: Use Node.js 16.18
uses: actions/setup-node@v3
with:
node-version: 16.14
node-version: 16.18
cache: "pnpm"

- name: Install workerd Dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/format-errors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
- uses: pnpm/action-setup@v2
with:
version: 8.8.0
- name: Use Node.js 16.14
- name: Use Node.js 16.18
uses: actions/setup-node@v3
with:
node-version: 16.14
node-version: 16.18
cache: "pnpm"

- name: Install workerd Dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ jobs:
- uses: pnpm/action-setup@v2
with:
version: 8.8.0
- name: Use Node.js 16.14
- name: Use Node.js 16.18
uses: actions/setup-node@v3
with:
node-version: 16.14
node-version: 16.18
cache: "pnpm"

- name: Install workerd Dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/playground-preview-worker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
- uses: pnpm/action-setup@v2
with:
version: 8.8.0
- name: Use Node.js 16.14
- name: Use Node.js 16.18
uses: actions/setup-node@v3
with:
node-version: 16.14
node-version: 16.18
cache: "pnpm"

- name: Install workerd Dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/prerelease-create-cloudflare.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ jobs:
- uses: pnpm/action-setup@v2
with:
version: 8.8.0
- name: Use Node.js 16.14
- name: Use Node.js 16.18
uses: actions/setup-node@v3
with:
node-version: 16.14
node-version: 16.18
cache: "pnpm"

- name: Install workerd Dependencies
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/prereleases.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
- uses: pnpm/action-setup@v2
with:
version: 8.8.0
- name: Use Node.js 16.14
- name: Use Node.js 16.18
uses: actions/setup-node@v3
with:
node-version: 16.14
node-version: 16.18
cache: "pnpm"

- name: "Create .env file"
Expand Down Expand Up @@ -83,10 +83,10 @@ jobs:
- uses: pnpm/action-setup@v2
with:
version: 8.8.0
- name: Use Node.js 16.14
- name: Use Node.js 16.18
uses: actions/setup-node@v3
with:
node-version: 16.14
node-version: 16.18
cache: "pnpm"

- name: Install workerd Dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pullrequests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Pull Request
on: pull_request

env:
node-version: 16.14
node-version: 16.18
jobs:
add-to-project:
name: Add PR to project
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/queues.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
- uses: pnpm/action-setup@v2
with:
version: 8.8.0
- name: Use Node.js 16.14
- name: Use Node.js 16.18
uses: actions/setup-node@v3
with:
node-version: 16.14
node-version: 16.18
cache: "pnpm"

- name: Install workerd Dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ jobs:
- uses: pnpm/action-setup@v2
with:
version: 8.8.0
- name: Use Node.js 16.14
- name: Use Node.js 16.18
uses: actions/setup-node@v3
with:
node-version: 16.14
node-version: 16.18
cache: "pnpm"

- name: Install workerd Dependencies
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"turbo": "^1.10.14"
},
"engines": {
"node": ">=16.13.0"
"node": ">=16.17.0"
},
"volta": {
"node": "16.13.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/wrangler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,6 @@
"fsevents": "~2.3.2"
},
"engines": {
"node": ">=16.13.0"
"node": ">=16.17.0"
}
}