Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(workers): allow namespaced scripts to be used as Worker tail consumers" #4447

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

penalosa
Copy link
Contributor

Reverts #3845

@penalosa penalosa requested a review from a team as a code owner November 15, 2023 13:42
Copy link

changeset-bot bot commented Nov 15, 2023

⚠️ No Changeset found

Latest commit: 7224dc3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6878114272/npm-package-wrangler-4447

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6878114272/npm-package-wrangler-4447

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6878114272/npm-package-wrangler-4447 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6878114272/npm-package-miniflare-4447
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6878114272/npm-package-cloudflare-pages-shared-4447

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.15.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231025.1
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #4447 (7224dc3) into main (be36619) will increase coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4447      +/-   ##
==========================================
+ Coverage   75.46%   75.50%   +0.03%     
==========================================
  Files         225      225              
  Lines       12478    12478              
  Branches     3239     3239              
==========================================
+ Hits         9417     9421       +4     
+ Misses       3061     3057       -4     

see 3 files with indirect coverage changes

@penalosa penalosa merged commit 3753eaf into main Nov 15, 2023
17 checks passed
@penalosa penalosa deleted the revert-3845-feat/workers-ns-tail-scripts branch November 15, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants