Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat(workers): allow namespaced scripts to be used as Worker tail consumers" #4447

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Revert "feat(workers): allow namespaced scripts to be used as Worker tail consumers" #4447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .changeset/thin-pears-repeat.md
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/wrangler/src/__tests__/configuration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4772,7 +4772,6 @@ describe("normalizeAndValidateConfig()", () => {
// these are valid
{ service: "tail_listener" },
{ service: "listener_two", environment: "production" },
{ service: "listener_three", namespace: "a-dispatch-namespace" },
],
} as unknown as RawConfig,
undefined,
Expand Down
2 changes: 0 additions & 2 deletions packages/wrangler/src/__tests__/deploy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5135,7 +5135,6 @@ addEventListener('fetch', event => {});`
tail_consumers: [
{ service: "listener " },
{ service: "test-listener", environment: "production" },
{ service: "namespaced-listener", namespace: "a-dispatch-namespace" },
],
});
await fs.promises.writeFile("index.js", `export default {};`);
Expand All @@ -5144,7 +5143,6 @@ addEventListener('fetch', event => {});`
expectedTailConsumers: [
{ service: "listener " },
{ service: "test-listener", environment: "production" },
{ service: "namespaced-listener", namespace: "a-dispatch-namespace" },
],
});

Expand Down
4 changes: 1 addition & 3 deletions packages/wrangler/src/config/environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,10 +734,8 @@ export type ConfigModuleRuleType =
export type TailConsumer = {
/** The name of the service tail events will be forwarded to. */
service: string;
/** (Optional) The environment of the service. */
/** (Optional) The environt of the service. */
environment?: string;
/** (Optional) The dispatch namespace the Tail Worker script belongs to (if any). */
namespace?: string;
};

export interface DispatchNamespaceOutbound {
Expand Down
1 change: 0 additions & 1 deletion packages/wrangler/src/deployment-bundle/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,6 @@ export interface CfPlacement {
export interface CfTailConsumer {
service: string;
environment?: string;
namespace?: string;
}

export interface CfUserLimits {
Expand Down