Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use partitioned cookies #5004

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Use partitioned cookies #5004

merged 6 commits into from
Feb 13, 2024

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Feb 13, 2024

Partially fixes DEVX-1156. There will be a followup PR to address the same issue in edge-preview-authenticated-proxy (#5016)

What this PR solves / how to test:

This PR ensures that the Workers Playground uses partitioned cookies for it's preview system, to address the upcoming deprecation of third party cookies in Chrome.

This PR can be tested by following the steps in packages/workers-playground/README.md to build a local copy of the playground, and then running it in a version of chrome with the cookie phaseout flag enabled (chrome://flags#test-third-party-cookie-phaseout)

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because: This relies on manual testing in a version of chrome with the flag enabled
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because: The package doesn't follow changesets
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: This isn't a change to documented behaviour

@penalosa penalosa requested a review from a team as a code owner February 13, 2024 14:28
Copy link

changeset-bot bot commented Feb 13, 2024

⚠️ No Changeset found

Latest commit: 33464dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@penalosa penalosa force-pushed the penalosa/rws-experiments branch from 7079fb3 to 8d71f79 Compare February 13, 2024 14:30
Copy link
Contributor

github-actions bot commented Feb 13, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7888932488/npm-package-wrangler-5004

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5004/npm-package-wrangler-5004

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7888932488/npm-package-wrangler-5004 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7888932488/npm-package-create-cloudflare-5004 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7888932488/npm-package-cloudflare-kv-asset-handler-5004
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7888932488/npm-package-miniflare-5004
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7888932488/npm-package-cloudflare-pages-shared-5004

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.28.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240129.1
workerd 1.20240129.0 1.20240129.0
workerd --version 1.20240129.0 2024-01-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ad8ddd) 70.45% compared to head (33464dd) 70.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5004      +/-   ##
==========================================
+ Coverage   70.45%   70.50%   +0.05%     
==========================================
  Files         295      295              
  Lines       15411    15411              
  Branches     3948     3948              
==========================================
+ Hits        10858    10866       +8     
+ Misses       4553     4545       -8     

see 6 files with indirect coverage changes

@penalosa penalosa added test:playground-worker playground-worker Bug or feature on the CF Workers Playground Worker and removed test:playground-worker labels Feb 13, 2024
Copy link

gitguardian bot commented Feb 13, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@penalosa penalosa force-pushed the penalosa/rws-experiments branch from 124e614 to 315bc87 Compare February 13, 2024 14:52
@penalosa
Copy link
Contributor Author

penalosa commented Feb 13, 2024

There are no secrets present in this pull request anymore.

For future reference, this was a false positive—it detected a user token for the playground in one of the test snapshots

@penalosa penalosa merged commit b9b34ce into main Feb 13, 2024
17 checks passed
@penalosa penalosa deleted the penalosa/rws-experiments branch February 13, 2024 23:33
@lrapoport-cf
Copy link
Contributor

for posterity: @1000hz tested this locally and can confirm that it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playground-worker Bug or feature on the CF Workers Playground Worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants