-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use partitioned cookies #5004
Use partitioned cookies #5004
Conversation
|
7079fb3
to
8d71f79
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7888932488/npm-package-wrangler-5004 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5004/npm-package-wrangler-5004 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7888932488/npm-package-wrangler-5004 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7888932488/npm-package-create-cloudflare-5004 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7888932488/npm-package-cloudflare-kv-asset-handler-5004 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7888932488/npm-package-miniflare-5004 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7888932488/npm-package-cloudflare-pages-shared-5004 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5004 +/- ##
==========================================
+ Coverage 70.45% 70.50% +0.05%
==========================================
Files 295 295
Lines 15411 15411
Branches 3948 3948
==========================================
+ Hits 10858 10866 +8
+ Misses 4553 4545 -8 |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
124e614
to
315bc87
Compare
For future reference, this was a false positive—it detected a user token for the playground in one of the test snapshots |
for posterity: @1000hz tested this locally and can confirm that it works |
Partially fixes DEVX-1156. There will be a followup PR to address the same issue in
edge-preview-authenticated-proxy
(#5016)What this PR solves / how to test:
This PR ensures that the Workers Playground uses partitioned cookies for it's preview system, to address the upcoming deprecation of third party cookies in Chrome.
This PR can be tested by following the steps in
packages/workers-playground/README.md
to build a local copy of the playground, and then running it in a version of chrome with the cookie phaseout flag enabled (chrome://flags#test-third-party-cookie-phaseout
)Author has addressed the following: