-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[quick-edit] Partitioned cookies #5016
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7962711882/npm-package-wrangler-5016 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5016/npm-package-wrangler-5016 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7962711882/npm-package-wrangler-5016 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7962711882/npm-package-create-cloudflare-5016 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7962711882/npm-package-cloudflare-kv-asset-handler-5016 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7962711882/npm-package-miniflare-5016 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7962711882/npm-package-cloudflare-pages-shared-5016 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7962711882/npm-package-cloudflare-vitest-pool-workers-5016 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5016 +/- ##
==========================================
+ Coverage 70.33% 70.36% +0.02%
==========================================
Files 297 298 +1
Lines 15458 15463 +5
Branches 3966 3966
==========================================
+ Hits 10872 10880 +8
+ Misses 4586 4583 -3 |
@petebacondarwin @RamIdeas, this contains a change to #4950, which was breaking |
2f7a0e0
to
e9ef80d
Compare
I tested these changes locally and verified they are working. |
a99be39
to
3dee9ce
Compare
Love it! But sadly legit failures in CI to deal with before landing. |
Closes DEVX-1156.
What this PR solves / how to test:
This PR ensures that the Workers Quick Edit uses partitioned cookies for it's preview system, to address the upcoming deprecation of third party cookies in Chrome.
Testing instructions TBD
Author has addressed the following: