Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[quick-edit] Partitioned cookies #5016

Merged
merged 8 commits into from
Feb 19, 2024

Conversation

penalosa
Copy link
Contributor

Closes DEVX-1156.

What this PR solves / how to test:

This PR ensures that the Workers Quick Edit uses partitioned cookies for it's preview system, to address the upcoming deprecation of third party cookies in Chrome.

Testing instructions TBD

Author has addressed the following:

  • Tests
    • Included, but manual testing in Chrome TBD
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because: The package doesn't follow changesets
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: This isn't a change to documented behaviour

@penalosa penalosa requested a review from a team as a code owner February 14, 2024 19:19
Copy link

changeset-bot bot commented Feb 14, 2024

⚠️ No Changeset found

Latest commit: 2f3f56b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 14, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7962711882/npm-package-wrangler-5016

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5016/npm-package-wrangler-5016

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7962711882/npm-package-wrangler-5016 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7962711882/npm-package-create-cloudflare-5016 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7962711882/npm-package-cloudflare-kv-asset-handler-5016
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7962711882/npm-package-miniflare-5016
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7962711882/npm-package-cloudflare-pages-shared-5016
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7962711882/npm-package-cloudflare-vitest-pool-workers-5016

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.28.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240129.3
workerd 1.20240129.0 1.20240129.0
workerd --version 1.20240129.0 2024-01-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d33946b) 70.33% compared to head (2f3f56b) 70.36%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5016      +/-   ##
==========================================
+ Coverage   70.33%   70.36%   +0.02%     
==========================================
  Files         297      298       +1     
  Lines       15458    15463       +5     
  Branches     3966     3966              
==========================================
+ Hits        10872    10880       +8     
+ Misses       4586     4583       -3     

see 8 files with indirect coverage changes

@penalosa
Copy link
Contributor Author

@petebacondarwin @RamIdeas, this contains a change to #4950, which was breaking set-cookie headers (which require a hostname, not host). I'm not entirely sure about the change though, so would appreciate a review!

@penalosa penalosa force-pushed the penalosa/partitioned-cookies-quick-edit branch 2 times, most recently from 2f7a0e0 to e9ef80d Compare February 16, 2024 19:14
@1000hz
Copy link
Contributor

1000hz commented Feb 16, 2024

I tested these changes locally and verified they are working.

@penalosa penalosa force-pushed the penalosa/partitioned-cookies-quick-edit branch from a99be39 to 3dee9ce Compare February 19, 2024 11:56
@petebacondarwin
Copy link
Contributor

Love it! But sadly legit failures in CI to deal with before landing.

@penalosa penalosa merged commit 01e0846 into main Feb 19, 2024
17 checks passed
@penalosa penalosa deleted the penalosa/partitioned-cookies-quick-edit branch February 19, 2024 17:23
@lrapoport-cf lrapoport-cf mentioned this pull request Feb 22, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants