-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump vitest in create-cloudflare templates #5863
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9143438724/npm-package-wrangler-5863 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5863/npm-package-wrangler-5863 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9143438724/npm-package-wrangler-5863 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9143438724/npm-package-create-cloudflare-5863 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9143438724/npm-package-cloudflare-kv-asset-handler-5863 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9143438724/npm-package-miniflare-5863 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9143438724/npm-package-cloudflare-pages-shared-5863 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9143438724/npm-package-cloudflare-vitest-pool-workers-5863 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
I'll run the e2e tests before merging... |
Thanks. There are some other type errors here that I'm not really sure why are happening honestly. I'll see if I can get a chance to look over them at some point this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unapproving while we work out the failures
Didn't notice this open PR, I picked it up in #6076. I did only mark vitest to 1.5.0, I'll mark it up in 1.5.3 in the next release. Thank you very much for your PR! |
What this PR solves / how to test
This simply updates the create-cloudflare templates to use a newer vitest version, as a followup to #5458 now that's been released.
Fixes #[insert GH or internal issue number(s)].
Author has addressed the following