Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c3: use latest dependencies for hello-world templates #6076

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

threepointone
Copy link
Contributor

@threepointone threepointone commented Jun 18, 2024

When generating a plain hello world worker, we're picking up older versions of vitest/pool-workers. this updates the package.jsons to pick up newer versions instead. Ideally we should automate this, but we can do that later. I also updated the wrangler deps to the current version so it's clearer for developers what they're using (still not accurate, but better than showing 3.0.0). Again, this should be automated, but we can do that later.

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: alreacy covered by tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: already covered
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: no functional change

@threepointone threepointone requested review from a team as code owners June 18, 2024 09:06
Copy link

changeset-bot bot commented Jun 18, 2024

🦋 Changeset detected

Latest commit: 9180002

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 18, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9563036890/npm-package-wrangler-6076

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6076/npm-package-wrangler-6076

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9563036890/npm-package-wrangler-6076 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9563036890/npm-package-create-cloudflare-6076 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9563036890/npm-package-cloudflare-kv-asset-handler-6076
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9563036890/npm-package-miniflare-6076
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9563036890/npm-package-cloudflare-pages-shared-6076
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9563036890/npm-package-cloudflare-vitest-pool-workers-6076

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.60.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.0
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

When generating a plain hello world worker, we're picking up older versions of vitest/pool-workers. this updates the package.jsons to pick up newer versions instead. Ideally we should automate this, but we can do that later. I also updated the wrangler deps to the current version so it's clearer for developers what they're using (still not accurate, but better than showing 3.0.0). Again, this should be automated, but we can do that later.
@threepointone threepointone added the e2e Run e2e tests on a PR label Jun 18, 2024
@petebacondarwin petebacondarwin merged commit 9487179 into main Jun 18, 2024
30 of 31 checks passed
@petebacondarwin petebacondarwin deleted the c3-newer-wrangler-vitest-deps branch June 18, 2024 11:28
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Jun 18, 2024
Copy link

holopin-bot bot commented Jun 18, 2024

Congratulations @threepointone, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxkbn9y403710cmpqm6ri6cp

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small e2e Run e2e tests on a PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants