Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quick-edit): disable autosave #6558

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Aug 22, 2024

What this PR solves / how to test

Fixes DEVX-1306.

This PR disables the autosave setting in vscode to avoid context reset without explicit user action.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: Settings update
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: Settings update

Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: f0cdc4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/quick-edit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 22, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10509066936/npm-package-wrangler-6558

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6558/npm-package-wrangler-6558

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10509066936/npm-package-wrangler-6558 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10509066936/npm-package-create-cloudflare-6558 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10509066936/npm-package-cloudflare-kv-asset-handler-6558
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10509066936/npm-package-miniflare-6558
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10509066936/npm-package-cloudflare-pages-shared-6558
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10509066936/npm-package-cloudflare-vitest-pool-workers-6558
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10509066936/npm-package-cloudflare-workers-editor-shared-6558
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10509066936/npm-package-cloudflare-workers-shared-6558

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.72.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.1
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@@ -16,6 +16,7 @@ export const onRequest = async ({
: "Solarflare Light",
"workbench.startupEditor": "none",
"editor.minimap.autohide": true,
"files.autoSave": "off",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting the autosave to be disabled by default and it was enabled by us somewhere. However I couldn't find anywhere we set it to afterDelay. 🤔

@edmundhung edmundhung marked this pull request as ready for review August 22, 2024 13:28
@edmundhung edmundhung requested a review from a team as a code owner August 22, 2024 13:28
@penalosa penalosa merged commit 2a5b648 into main Aug 27, 2024
18 checks passed
@penalosa penalosa deleted the edmundhung/quick-edit-disable-autosave branch August 27, 2024 18:25
penalosa added a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants