Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(quick-edit): disable autosave #6558

Merged
merged 2 commits into from
Aug 27, 2024
Merged

fix(quick-edit): disable autosave #6558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0577b99
fix(quick-edit): disable autosave
edmundhung Aug 22, 2024
f0cdc4d
Create forty-taxis-live.md
edmundhung Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/forty-taxis-live.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cloudflare/quick-edit": patch
---

fix: disable autosave on quick editor to avoid context reset without explicit user action
1 change: 1 addition & 0 deletions packages/quick-edit/functions/_middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export const onRequest = async ({
: "Solarflare Light",
"workbench.startupEditor": "none",
"editor.minimap.autohide": true,
"files.autoSave": "off",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting the autosave to be disabled by default and it was enabled by us somewhere. However I couldn't find anywhere we set it to afterDelay. 🤔

"files.exclude": {
"*.d.ts": true,
"jsconfig.json": true,
Expand Down
Loading