Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove the warning about local mode flag being removed in the future #6563

Merged
merged 1 commit into from
Aug 27, 2024
Merged

chore: remove the warning about local mode flag being removed in the future #6563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/clean-rockets-decide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": patch
---

chore: remove the warning about local mode flag being removed in the future
7 changes: 0 additions & 7 deletions fixtures/pages-functions-app/tests/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,6 @@ describe("Pages Functions", () => {
expect(text).toContain("<h1>An asset</h1>");
});

it("doesn't warn about local mode", async ({ expect }) => {
// Regression test for https://github.com/cloudflare/workers-sdk/issues/4210
expect(getOutput()).not.toContain(
"--local is no longer required and will be removed in a future version"
);
});

describe("can mount a plugin", () => {
it("should mount Middleware", async ({ expect }) => {
const response = await fetch(
Expand Down
6 changes: 0 additions & 6 deletions packages/wrangler/src/dev.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,12 +557,6 @@ export async function startDev(args: StartDevOptions) {
logger.loggerLevel = args.logLevel;
}

if (args.local) {
logger.warn(
"--local is no longer required and will be removed in a future version.\n`wrangler dev` now uses the local Cloudflare Workers runtime by default. 🎉"
);
}

if (args.experimentalLocal) {
logger.warn(
"--experimental-local is no longer required and will be removed in a future version.\n`wrangler dev` now uses the local Cloudflare Workers runtime by default. 🎉"
Expand Down
Loading