Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the warning about local mode flag being removed in the future #6563

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

threepointone
Copy link
Contributor

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included (updated tests
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: no functional changes
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: no functional changes

@threepointone threepointone requested review from a team as code owners August 23, 2024 08:14
Copy link

changeset-bot bot commented Aug 23, 2024

🦋 Changeset detected

Latest commit: 82ff460

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Aug 23, 2024
Copy link
Contributor

github-actions bot commented Aug 23, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523081533/npm-package-wrangler-6563

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6563/npm-package-wrangler-6563

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523081533/npm-package-wrangler-6563 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523081533/npm-package-create-cloudflare-6563 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523081533/npm-package-cloudflare-kv-asset-handler-6563
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523081533/npm-package-miniflare-6563
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523081533/npm-package-cloudflare-pages-shared-6563
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523081533/npm-package-cloudflare-vitest-pool-workers-6563
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523081533/npm-package-cloudflare-workers-editor-shared-6563
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523081533/npm-package-cloudflare-workers-shared-6563

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.72.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.0
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

packages/wrangler/src/dev.tsx Outdated Show resolved Hide resolved
packages/wrangler/src/pages/dev.ts Outdated Show resolved Hide resolved
@threepointone
Copy link
Contributor Author

I assume the flaky tests aren't related to this PR, so it's probably ready to land?

@penalosa penalosa merged commit da48a70 into main Aug 27, 2024
20 checks passed
@penalosa penalosa deleted the remove-local-removal-warning branch August 27, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants