feat:wrangler dev with dynamic sites + miniflare assets plugin
#6564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3b4d90f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
emily-shen
force-pushed
the
emily/assets-plugin-refactor
branch
from
96da898 to
6ef84d5
Compare
emily-shen
changed the title
wrangler dev with dynamic siteswrangler dev with dynamic sites + miniflare assets plugin
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10634012860/npm-package-wrangler-6564You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6564/npm-package-wrangler-6564Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10634012860/npm-package-wrangler-6564 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10634012860/npm-package-create-cloudflare-6564 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10634012860/npm-package-cloudflare-kv-asset-handler-6564npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10634012860/npm-package-miniflare-6564npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10634012860/npm-package-cloudflare-pages-shared-6564npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10634012860/npm-package-cloudflare-vitest-pool-workers-6564npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10634012860/npm-package-cloudflare-workers-editor-shared-6564npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10634012860/npm-package-cloudflare-workers-shared-6564Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
emily-shen
force-pushed
the
emily/assets-plugin-refactor
branch
6 times, most recently
from
6ab6490 to
1c8d39b
Compare
Merged
12 tasks
emily-shen
force-pushed
the
emily/assets-plugin-refactor
branch
4 times, most recently
from
a2883c9 to
0077d5e
Compare
emily-shen
force-pushed
the
emily/assets-plugin-refactor
branch
from
1431074 to
5e56c5c
Compare
12 tasks
|
|
||
| `workers-with-assets` is a test fixture that showcases Workers with Assets. This particular fixture sets up an assets-only Workers project. | ||
| `workers-assets-with-user-worker"` is a test fixture that showcases Workers with Assets. This particular fixture sets up a User Worker, assets, and a binding from the user Worker to the assets. |
CarmenPopoviciu
approved these changes
Aug 30, 2024
emily-shen
force-pushed
the
emily/assets-plugin-refactor
branch
from
5e56c5c to
83fcef8
Compare
RamIdeas
reviewed
Aug 30, 2024
packages/miniflare/src/index.ts
Outdated
| @@ -1250,6 +1250,7 @@ export class Miniflare { | |||
| loopbackPort, | |||
| log: this.#log, | |||
| proxyBindings, | |||
| hasWorkerAssets: !!this.#workerOpts[0].assets.assets, | |||
There was a problem hiding this comment.
This is a fun assignment 😆
There was a problem hiding this comment.
hmmm...that is true
RamIdeas
reviewed
Aug 30, 2024
RamIdeas
reviewed
Aug 30, 2024
RamIdeas
approved these changes
Aug 30, 2024
CarmenPopoviciu
force-pushed
the
emily/assets-plugin-refactor
branch
from
1048a0f to
514e943
Compare
CarmenPopoviciu
force-pushed
the
emily/assets-plugin-refactor
branch
from
61909d3 to
3b4d90f
Compare
Merged
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
This creates a new
assetsminiflare plugin. The Asset Worker and Router Worker are imported fromworkers-sharedand used as miniflare services. If assets are detected, the miniflare entry worker will always point towards the Router Worker instead of the User Worker like it usually does.We also add in a config object that can be passed to Router Worker. Currently this only contains
{hasUserWorker: boolean}, but will be used later for other routing config.User Worker + Assets diagram. If there is no UW, this remains the same except wrangler provides a no-op worker that cannot be reached.
Author has addressed the following