Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workers-shared): Add asset-worker configuration file to workers-shared distribution #6590

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Aug 28, 2024

What this PR solves / how to test

Wrangler has a dependency on workers-shared, specifically on the bundled Asset Worker here, and the Asset Worker config file here. Currently the wrangler.toml file is not included in the workers-shared distribution, which results in that import failing with Error: Cannot find module '@cloudflare/workers-shared/asset-server-worker/wrangler.toml'.

This PR copies the config file to the distribution folder dist, so that wrangler can properly import it, and folks can test experimental assets with wrangler dev.

Note:

Fixes WC-2623

How this was tested

Tested with a demo Workers + Assets project (outside workers-sdk) + wrangler prerelease
Screenshot 2024-08-28 at 11 58 12

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: build script changes
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: build script changes
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: build script changes
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: AW is not documented

@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner August 28, 2024 09:02
Copy link

changeset-bot bot commented Aug 28, 2024

⚠️ No Changeset found

Latest commit: 90025ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 28, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10594673997/npm-package-wrangler-6590

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6590/npm-package-wrangler-6590

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10594673997/npm-package-wrangler-6590 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10594673997/npm-package-create-cloudflare-6590 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10594673997/npm-package-cloudflare-kv-asset-handler-6590
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10594673997/npm-package-miniflare-6590
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10594673997/npm-package-cloudflare-pages-shared-6590
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10594673997/npm-package-cloudflare-vitest-pool-workers-6590
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10594673997/npm-package-cloudflare-workers-editor-shared-6590
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10594673997/npm-package-cloudflare-workers-shared-6590

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.72.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.0
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/copy-files branch 2 times, most recently from 9cad17f to 658de2e Compare August 28, 2024 09:51
@CarmenPopoviciu CarmenPopoviciu merged commit 344a636 into main Aug 28, 2024
21 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the carmen/copy-files branch August 28, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants