Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove experimental: prefix requirement for nodejs_compat_v2 #6593

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Aug 28, 2024

What this PR solves / how to test

This PR builds on top and supersedes #6545

Changes in this PR are in the last commit - the functionality stays the same but the code is re-organized.

Rename validateNodeCompat to getNodeCompatMode which is what the function does

Convert the parameters to optional options for better readability.

Added a `validateConfig` to be able to skip validation (used once in the code base).

The former getNodeCompatMode is now parseNodeCompatibilityFlags and is only responsible to return the compat flags and no more exported.

Improve the documentation

petebacondarwin and others added 6 commits August 28, 2024 15:22
Rename validateNodeCompat to getNodeCompatMode which is what the function does

Convert the parameters to optional options for better readability.

Added a `validateConfig` to be able to skip validation (used once in the code base).

The former getNodeCompatMode is now parseNodeCompatibilityFlags and is only responsible to return the compat flags and no more exported.

Improve the documentation
@vicb vicb requested a review from IgorMinar August 28, 2024 13:37
@vicb vicb requested review from a team as code owners August 28, 2024 13:37
Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: 510898e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10597846504/npm-package-wrangler-6593

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6593/npm-package-wrangler-6593

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10597846504/npm-package-wrangler-6593 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10597846504/npm-package-create-cloudflare-6593 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10597846504/npm-package-cloudflare-kv-asset-handler-6593
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10597846504/npm-package-miniflare-6593
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10597846504/npm-package-cloudflare-pages-shared-6593
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10597846504/npm-package-cloudflare-vitest-pool-workers-6593
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10597846504/npm-package-cloudflare-workers-editor-shared-6593
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10597846504/npm-package-cloudflare-workers-shared-6593

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.72.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.0
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I've reviewed mainly the public API and tests, and those look good to me. I rely on @RamIdeas's review for the implementation soundness.

Thank y'all!

@RamIdeas RamIdeas merged commit f097cb7 into cloudflare:main Aug 28, 2024
18 checks passed
@irvinebroque
Copy link
Contributor

thanks all cc @mikenomitch

@vicb vicb deleted the vicb/remove-nodejs_v2_experimental branch August 30, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants