-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove experimental: prefix requirement for nodejs_compat_v2 #6593
fix: remove experimental: prefix requirement for nodejs_compat_v2 #6593
Conversation
Rename validateNodeCompat to getNodeCompatMode which is what the function does Convert the parameters to optional options for better readability. Added a `validateConfig` to be able to skip validation (used once in the code base). The former getNodeCompatMode is now parseNodeCompatibilityFlags and is only responsible to return the compat flags and no more exported. Improve the documentation
🦋 Changeset detectedLatest commit: 510898e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10597846504/npm-package-wrangler-6593 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6593/npm-package-wrangler-6593 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10597846504/npm-package-wrangler-6593 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10597846504/npm-package-create-cloudflare-6593 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10597846504/npm-package-cloudflare-kv-asset-handler-6593 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10597846504/npm-package-miniflare-6593 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10597846504/npm-package-cloudflare-pages-shared-6593 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10597846504/npm-package-cloudflare-vitest-pool-workers-6593 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10597846504/npm-package-cloudflare-workers-editor-shared-6593 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10597846504/npm-package-cloudflare-workers-shared-6593 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I've reviewed mainly the public API and tests, and those look good to me. I rely on @RamIdeas's review for the implementation soundness.
Thank y'all!
thanks all cc @mikenomitch |
What this PR solves / how to test
This PR builds on top and supersedes #6545
Changes in this PR are in the last commit - the functionality stays the same but the code is re-organized.