Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove experimental: prefix requirement for nodejs_compat_v2 #6593

Merged
merged 6 commits into from
Aug 28, 2024
Merged

fix: remove experimental: prefix requirement for nodejs_compat_v2 #6593

merged 6 commits into from
Aug 28, 2024

Commits on Aug 28, 2024

  1. fix: remove experimental: prefix requirement for nodejs_compat_v2 

    See https://jira.cfdata.org/browse/DEVDASH-218
    @petebacondarwin @vicb
    petebacondarwin authored and vicb committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    3b43f99 View commit details
    Browse the repository at this point in the history

  2. PR review updates 2

    @petebacondarwin @vicb
    petebacondarwin authored and vicb committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    522ce87 View commit details
    Browse the repository at this point in the history

  3. PR review udpdates

    @petebacondarwin @vicb
    petebacondarwin authored and vicb committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    cb31212 View commit details
    Browse the repository at this point in the history

  4. add error message for invalid use of experimental prefix

    @petebacondarwin @vicb
    petebacondarwin authored and vicb committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    99e3e4d View commit details
    Browse the repository at this point in the history

  5. reworking parameters after feedback

    @petebacondarwin @vicb
    petebacondarwin authored and vicb committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    3e40999 View commit details
    Browse the repository at this point in the history

  6. fixup PR: 

    Rename validateNodeCompat to getNodeCompatMode which is what the function does

Convert the parameters to optional options for better readability.

Added a `validateConfig` to be able to skip validation (used once in the code base).

The former getNodeCompatMode is now parseNodeCompatibilityFlags and is only responsible to return the compat flags and no more exported.

Improve the documentation
    @vicb
    vicb committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    510898e View commit details
    Browse the repository at this point in the history