Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows commands #7015

Merged
merged 17 commits into from
Oct 18, 2024
Merged

Workflows commands #7015

merged 17 commits into from
Oct 18, 2024

Conversation

RamIdeas
Copy link
Contributor

@RamIdeas RamIdeas commented Oct 17, 2024

What this PR solves / how to test

Fixes #0000

Implementation for wrangler workflows ... commands. Refactored to use the defineCommand util.

Not tested right now but is isolated to just those commands – plan is to follow up with automated tests next week.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: isolated to wrangler workflows * commands, will add tests in a follow-up PR next week
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no e2e tests yet – follow up PR next week
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation

Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: fd82b95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@RamIdeas RamIdeas marked this pull request as ready for review October 18, 2024 01:11
@RamIdeas RamIdeas requested a review from a team as a code owner October 18, 2024 01:11
@RamIdeas RamIdeas mentioned this pull request Oct 18, 2024
12 tasks
Copy link
Contributor

github-actions bot commented Oct 18, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11407867452/npm-package-wrangler-7015

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7015/npm-package-wrangler-7015

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11407867452/npm-package-wrangler-7015 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11407867452/npm-package-create-cloudflare-7015 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11407867452/npm-package-cloudflare-kv-asset-handler-7015
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11407867452/npm-package-miniflare-7015
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11407867452/npm-package-cloudflare-pages-shared-7015
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11407867452/npm-package-cloudflare-vitest-pool-workers-7015
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11407867452/npm-package-cloudflare-workers-editor-shared-7015
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11407867452/npm-package-cloudflare-workers-shared-7015

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.81.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241011.0
workerd 1.20241011.1 1.20241011.1
workerd --version 1.20241011.1 2024-10-11

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@andyjessop andyjessop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work - can't wait to see this land. It's fantastic to see defineCommand in action - it definitely helps to keep things clean and straightforward.

metadata: {
description:
"Delete workflow - when deleting a workflow, it will also delete it's own instances",
owner: "Product: Workflows",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might think about creating a separate owners config, which would help to keep this consistent over time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered this in the design but I think the granularity and colocation trump the duplication and especially since it will be infrequently changed

packages/wrangler/src/workflows/commands/instances/list.ts Outdated Show resolved Hide resolved
Base automatically changed from workflows-binding to main October 18, 2024 16:11
@RamIdeas RamIdeas requested review from a team as code owners October 18, 2024 16:11
@RamIdeas RamIdeas merged commit 48152d6 into main Oct 18, 2024
20 checks passed
@RamIdeas RamIdeas deleted the workflows-commands branch October 18, 2024 17:14
@lrapoport-cf
Copy link
Contributor

placeholder issue as reminder to add tests: #7056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants