Fix wrangler module import under npm monorepos

[nickbabcock]

This PR updates import resolution for files and package exports

In an npm workspace environment, wrangler will now be able to successfully resolve package exports.

Previously, wrangler would only be able to resolve modules in a relative node_modules directory and not workspace root node_modules directory.

Installing locally fixes #7129

---

Soft ping to @Cherry who originally implemented this feature, some extra eyes would be appreciated 👀

---

• Tests
  • TODO (before merge)
  • Tests included
  • Tests not necessary because:
• E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • I don't know
  • Required
  • Not required because: passing on run e2e tests on #7130 #7283
• Public documentation
  • TODO (before merge)
  • Cloudflare docs PR(s):
  • Documentation not necessary because: as this implements the behavior implied by documentation.

[changeset-bot]

🦋 Changeset detected

Latest commit: 1d89a0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Minor
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Cherry]

Thanks for the ping!

Do the tests added for #4135 and #4748, with those use-cases, still work as expected here? I had issues getting require.resolve to play nicely unfortunately.

[nickbabcock]

That was my concern too, but (unless I'm missing something) they pass locally when I execute:

pnpm run --filter import-wasm-example test:watch

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12058466768/npm-package-wrangler-7130

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7130/npm-package-wrangler-7130

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12058466768/npm-package-wrangler-7130 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12058466768/npm-package-create-cloudflare-7130 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12058466768/npm-package-cloudflare-kv-asset-handler-7130

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12058466768/npm-package-miniflare-7130

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12058466768/npm-package-cloudflare-pages-shared-7130

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12058466768/npm-package-cloudflare-vitest-pool-workers-7130

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12058466768/npm-package-cloudflare-workers-editor-shared-7130

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12058466768/npm-package-cloudflare-workers-shared-7130

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12058466768/npm-package-cloudflare-workflows-shared-7130

Note that these links will no longer work once the GitHub Actions artifact expires.

---

wrangler@3.91.0 includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20241106.1
workerd	1.20241106.1	1.20241106.1
workerd --version	1.20241106.1	2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[nickbabcock]

Ah, I should have been executing the following to know if I introduced regressions:

pnpm run test:ci --concurrency 1 --filter=./fixtures/import-wasm-example

Turns out I did, and reintroducing resolve for non-exported members fixed the issue.

I still need to add a test before this PR is good to go.

[nickbabcock]

Alright, added npm workspace fixture which demonstrates the PR fixing the bundling issue.

✅ PR now ready for further review.

[penalosa]

I think this might be better using esbuild's resolution algorithm rather than require.resolve()? Something along the lines of:

const resolved = await build.resolve(args.path, {
  kind: "import-statement",
  resolveDir: args.resolveDir,
  pluginData: {
	  skip: true,
  },
  });
  if (resolved.path) {
  filePath = resolved.path;
  }

with a check for pluginData.skip at the top of the onResolve() callback to prevent infinite loops.

[nickbabcock]

Updated to use esbuild's plugin. All the tests seem to pass. Is there a particular reason why you prefer the esbuild plugin vs require.resolve?

[emily-shen]

thanks so much for the contribution!

[holopin-bot]

Congratulations @nickbabcock, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm42xhoim138330cmhekqf8p5w

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!