Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PowerDNS references #270

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Remove PowerDNS references #270

merged 1 commit into from
Mar 22, 2024

Conversation

aramprice
Copy link
Member

This component is being removed from BOSH itself.

See cloudfoundry/bosh#2501

@cunnie @aramprice
Remove PowerDNS references
492c0b4 
This component is being removed from BOSH itself.

Signed-off-by: aram price <aram.price@broadcom.com>
@cunnie cunnie self-requested a review March 21, 2024 23:13
cunnie
cunnie approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@cunnie cunnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning the cruft!

@aramprice aramprice requested a review from jpalermo March 21, 2024 23:14
@aramprice aramprice mentioned this pull request Mar 22, 2024
Merged
@klakin-pivotal
Copy link
Contributor

Sure, this seems fine to me.

For reference, the deploy-manual-networking.sh file is used in the bats-ubuntu-manual Job in its deploy task. So, if we see that failing to deploy after this PR gets merged in, suspect this to be the cause.

@klakin-pivotal klakin-pivotal self-requested a review March 22, 2024 22:01
@klakin-pivotal klakin-pivotal merged commit 7814273 into master Mar 22, 2024
1 check passed
@aramprice aramprice deleted the remove-powerdns branch March 22, 2024 22:13
@klakin-pivotal klakin-pivotal mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klakin-pivotal klakin-pivotal klakin-pivotal approved these changes

@cunnie cunnie cunnie approved these changes

@jpalermo jpalermo Awaiting requested review from jpalermo

Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aramprice @klakin-pivotal @cunnie