Remove PowerDNS #2501
Merged
Remove PowerDNS #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramprice
force-pushed
the
remove-powerdns
branch
2 times, most recently
from
32ce79b to
10135a6
Compare
aramprice
force-pushed
the
remove-powerdns
branch
10 times, most recently
from
cd558e1 to
da93f01
Compare
aramprice
force-pushed
the
remove-powerdns
branch
2 times, most recently
from
14685fd to
8f2fdf5
Compare
aramprice
added a commit
to cloudfoundry/bosh-deployment
that referenced
this pull request
Mar 11, 2024
The PowerDNS package has not been updated since 2016. This commit removes: - `misc/powerdns.yml` This change is related to, but not dependent on, the removal of all PowerDNS packages, jobs, and cofig from the BOSH repo in the BOSH [PR 2501](cloudfoundry/bosh#2501) The removal of this ops-file is a way to signal that PowerDNS is no longer supported, and will be removed, see BOSH PR above.
aramprice
added a commit
to cloudfoundry/bosh-deployment
that referenced
this pull request
Mar 11, 2024
The PowerDNS package has not been updated since 2016. This commit removes: - `misc/powerdns.yml` This change is related to, but not dependent on, the removal of all PowerDNS packages, jobs, and cofig from the BOSH repo in this [PR 2501](cloudfoundry/bosh#2501) The removal of this ops-file is a way to signal that PowerDNS is no longer supported, and will be removed, see BOSH PR above.
This was referenced Mar 11, 2024
aramprice
force-pushed
the
remove-powerdns
branch
6 times, most recently
from
9da468b to
c98d2dd
Compare
aramprice
added a commit
to cloudfoundry/bosh-cli
that referenced
this pull request
Mar 20, 2024
PowerDNS is being removed from the BOSH Director, and as a consequence the data returned from the `instances` and `vms` commands no longer have DNS data returned. This commit removes the `--dns` flag and logic to display the data returnd when it is sent. See: cloudfoundry/bosh#2501
aramprice
added a commit
to cloudfoundry/bosh-cli
that referenced
this pull request
Mar 20, 2024
PowerDNS is being removed from the BOSH Director, and as a consequence the data returned from the `instances` and `vms` commands no longer have DNS data returned. This commit removes the `--dns` flag and logic to display the data returnd when it is sent. See: cloudfoundry/bosh#2501
jpalermo
requested review from
a team,
danielfor and
nouseforaname
and removed request for
a team
The PowerDNS package has not been updated since 2016. This commit
removes:
- package
- job
- all config values under `dns` except `domain_name`
- models under `src/bosh-director/lib/bosh/director/models/dns/`
- all mention or use of `dns_db` which was a separate database
configuration for these models
- removes `Instance#dns_records` and associated info from VM, and
Instance responses
- The content of this column was only ever populated when PowerDNS was
enabled
[#183367522]
aramprice
force-pushed
the
remove-powerdns
branch
from
c98d2dd to
13814f5
Compare
This was referenced Mar 21, 2024
aramprice
added a commit
to cloudfoundry/bosh-cli
that referenced
this pull request
Mar 22, 2024
PowerDNS is being removed from the BOSH Director, and as a consequence the data returned from the `instances` and `vms` commands no longer have DNS data returned. This commit removes the `--dns` flag and logic to display the data returnd when it is sent. See: cloudfoundry/bosh#2501
|
Question from cloudfoundry/bosh-cli#644 (comment)
cc @ystros |
The director code returning a Added an explicit test in the CLI to validate that PowerDNS-having-director responses are still handled: |
aramprice
added a commit
to cloudfoundry/bosh-cli
that referenced
this pull request
Mar 22, 2024
PowerDNS is being removed from the BOSH Director, and as a consequence the data returned from the `instances` and `vms` commands no longer have DNS data returned. This commit removes the `--dns` flag and logic to display the data returnd when it is sent. Add a spec to validate that the CLI continues to handle responses from directors which still have PowerDNS code. Concretely this means the VM info response has a `"dns"` key in it. See: cloudfoundry/bosh#2501
|
Let's wait for another approval on this because the change is quite large. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Remove PowerDNS
Please provide contextual information.
The PowerDNS package has not been updated since 2016. This commit removes:
dnsexceptdomain_namesrc/bosh-director/lib/bosh/director/models/dns/dns_dbwhich was a separate database configuration for these modelsWhat tests have you run against this PR?
✅
rake fly:unit✅
rake fly:integration✅
DB=mysql rake fly:integrationHow should this change be described in bosh release notes?
PowerDNS job and associated code is removed.
Does this PR introduce a breaking change?
Yes, operators who use PowerDNS will need to migrate to an alternative before upgrading to this release.
bosh-deployment's misc/powerdns.ymldocs-bosh--dnsflag and functionality fromboshCLI--dnsflag and related functionality bosh-cli#644