-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: upgrade to ginkgo v2 #75
Conversation
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/182454429 The labels on this github issue will be updated when the story is started. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me, assuming it builds. Looks much easier than the fun times in cats
I'm not confident that it will build as-is. There's some reporter stuff here as well. Won't know for sure until I run some tests. |
The junit reporter from my quick search won't work. Junit Reporter is now a command line flag https://onsi.github.io/ginkgo/MIGRATING_TO_V2#generating-machine-readable-reports |
* Remove TeamCity Reporter option, we don't use it in the smoke-tests release and the way we used it in ginkgo v1 is hard to replicate in ginkgo v2. * Use RunSpecs() over the deprecated RunSpecsWithDefaultAndCustomReporters(). * Can use GinkgoParallelProcess() to grab the parallel node directly rather than accessing the suite configuration.
I've tested the vanilla path (CF-D without windows or isolation segments) and seen it succeed. I think this is ready to merge. |
* go install is idempotent and can be run regardless of preexisting ginkgo CLIs. Don't need to specify a version as the command will pull that from the go.mod. * the slowSpecThreshold flag has a different name and accepts a duration value now. Continued passing it 300 seconds.
What is this change about?
Upgrade to gingko v2 to work with the same upgrade in cf-test-helpers.
Please provide contextual information.
Did you update the README as appropriate for this change?
How should this change be described in release notes?
Upgrade to ginkgo v2
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@moleske @cloudfoundry/app-runtime-deployments-wg-approvers