Feat: upgrade to ginkgo v2 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/182454429 The labels on this github issue will be updated when the story is started. |
moleske
approved these changes
Jun 13, 2022
|
I'm not confident that it will build as-is. There's some reporter stuff here as well. Won't know for sure until I run some tests. |
|
The junit reporter from my quick search won't work. Junit Reporter is now a command line flag https://onsi.github.io/ginkgo/MIGRATING_TO_V2#generating-machine-readable-reports |
* Remove TeamCity Reporter option, we don't use it in the smoke-tests release and the way we used it in ginkgo v1 is hard to replicate in ginkgo v2. * Use RunSpecs() over the deprecated RunSpecsWithDefaultAndCustomReporters(). * Can use GinkgoParallelProcess() to grab the parallel node directly rather than accessing the suite configuration.
ctlong
requested review from
a team and
davewalter
and removed request for
a team
|
I've tested the vanilla path (CF-D without windows or isolation segments) and seen it succeed. I think this is ready to merge. |
* go install is idempotent and can be run regardless of preexisting ginkgo CLIs. Don't need to specify a version as the command will pull that from the go.mod. * the slowSpecThreshold flag has a different name and accepts a duration value now. Continued passing it 300 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Upgrade to gingko v2 to work with the same upgrade in cf-test-helpers.
Please provide contextual information.
Did you update the README as appropriate for this change?
How should this change be described in release notes?
Upgrade to ginkgo v2
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@moleske @cloudfoundry/app-runtime-deployments-wg-approvers