Bump to ginkgo2 #58
Merged
Bump to ginkgo2 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-remove color feature cause couldn't understand how to use it in v2 Authored-by: Michael Oleske <moleske@pivotal.io>
7 tasks
- this is because you need to pass new reporter config to run specs - I don't like this because the seperation seems arbitrary without knowing how ginkgo v2 wants things setup - kept the tests neseted in command reporter to at least kinda keep the suites together Authored-by: Michael Oleske <moleske@pivotal.io>
|
IVe created my own fork to move to https://github.com/KevinJCross/cf-test-helpers we are actively using this fork in https://github.com/cloudfoundry/app-autoscaler-release seems stable and good enough to us. |
ctlong
approved these changes
Jun 3, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-remove color feature cause couldn't understand how to use it in v2
Authored-by: Michael Oleske moleske@pivotal.io