Update to ginkgo v2 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
silvestre
force-pushed
the
update-ginkgo
branch
from
75f57b0
to
2ac3291
Compare
Closed
Bump to current go, ginkgo, gomega Co-authored-by: Kevin Cross <kevin.cross@sap.com>
silvestre
force-pushed
the
update-ginkgo
branch
from
2ac3291
to
ae171bf
Compare
PlamenDoychev
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Looks good to me!
This PR addresses my comments in [1].
I think we can merge this one and close [1] as @KevinJCross is no longer at SAP.
[1] #18
Regards,
Plamen Doychev
|
@ameowlia, what is the next step, who can merge the PR? Regards, |
|
Thank you @ameowlia and @PlamenDoychev ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #18 which was opened by a previous coworker of mine.
Besides updating Ginkgo to v2 it also bumps the go and gomega versions.
The go version was bumped to 1.19 as 1.20 release candidates have been published and the EoL of 1.18 is imminent. (1.16 is unsupported since almost two years)
The go.mod file is now up-to-date with regards to direct and indirect dependencies.