Updating to ginkgo v2 #18
Conversation
|
Asked in #Diego for a review |
| @@ -1,9 +1,18 @@ | |||
| module code.cloudfoundry.org/cfhttp | |||
|
|
|||
| go 1.16 | |||
| go 1.17 | |||
There was a problem hiding this comment.
Perhaps it is worth mentioning that the PR bumps the golang version as well.
There was a problem hiding this comment.
BTW: What do you think if we separate the golang version bump and ginkgo /v2/ into separate PRs? What about bumping to latest golang version?
There was a problem hiding this comment.
I have added a bump to the current 1.19 in #28
|
|
||
| require ( | ||
| github.com/golang/protobuf v1.5.2 // indirect | ||
| golang.org/x/net v0.0.0-20220225172249-27dd8689420f // indirect |
There was a problem hiding this comment.
Do we really need this import? The version used seems to be not official. Most probably because the PR is from the beginning of March 2022 and there haven't been official release of the library.
Perhaps it is worth updating the PR (go modules) with latest dependencies used.
There was a problem hiding this comment.
I have added a bump to latest direct and indirect dependencies in #28
| require ( | ||
| github.com/golang/protobuf v1.5.2 // indirect | ||
| golang.org/x/net v0.0.0-20220225172249-27dd8689420f // indirect | ||
| golang.org/x/sys v0.0.0-20220227234510-4e6760a101f9 // indirect |
There was a problem hiding this comment.
Do we really need this import? The version used seems to be not official. Most probably because the PR is from the beginning of March 2022 and there haven't been official release of the library.
Perhaps it is worth updating the PR (go modules) with latest dependencies used.
There was a problem hiding this comment.
I have added a bump to latest direct and indirect dependencies in #28
|
@PlamenDoychev : As @KevinJCross has left SAP I have created a new PR #28 based on this one addressing your review comments. Could you please review #28 ? Thank you! |
|
Closing out this PR per #18 (comment) |
No description provided.