-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating to ginkgo v2 #18
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,18 @@ | ||
module code.cloudfoundry.org/cfhttp | ||
|
||
go 1.16 | ||
go 1.17 | ||
|
||
require ( | ||
github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d | ||
github.com/onsi/ginkgo v1.16.2 | ||
github.com/onsi/gomega v1.12.0 | ||
github.com/onsi/ginkgo/v2 v2.1.3 | ||
github.com/onsi/gomega v1.18.1 | ||
) | ||
|
||
require ( | ||
github.com/golang/protobuf v1.5.2 // indirect | ||
golang.org/x/net v0.0.0-20220225172249-27dd8689420f // indirect | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we really need this import? The version used seems to be not official. Most probably because the PR is from the beginning of March 2022 and there haven't been official release of the library. Perhaps it is worth updating the PR (go modules) with latest dependencies used. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have added a bump to latest direct and indirect dependencies in #28 |
||
golang.org/x/sys v0.0.0-20220227234510-4e6760a101f9 // indirect | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we really need this import? The version used seems to be not official. Most probably because the PR is from the beginning of March 2022 and there haven't been official release of the library. Perhaps it is worth updating the PR (go modules) with latest dependencies used. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have added a bump to latest direct and indirect dependencies in #28 |
||
golang.org/x/text v0.3.7 // indirect | ||
google.golang.org/protobuf v1.26.0 // indirect | ||
gopkg.in/yaml.v2 v2.4.0 // indirect | ||
) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,17 @@ | ||
module code.cloudfoundry.org/cfhttp/v2 | ||
|
||
go 1.17 | ||
|
||
require ( | ||
github.com/onsi/ginkgo/v2 v2.1.3 | ||
github.com/onsi/gomega v1.18.1 | ||
) | ||
|
||
require ( | ||
github.com/onsi/ginkgo v1.7.0 | ||
github.com/onsi/gomega v1.4.3 | ||
github.com/golang/protobuf v1.5.2 // indirect | ||
golang.org/x/net v0.0.0-20220225172249-27dd8689420f // indirect | ||
golang.org/x/sys v0.0.0-20211216021012-1d35b9e2eb4e // indirect | ||
golang.org/x/text v0.3.7 // indirect | ||
google.golang.org/protobuf v1.26.0 // indirect | ||
gopkg.in/yaml.v2 v2.4.0 // indirect | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it is worth mentioning that the PR bumps the golang version as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW: What do you think if we separate the golang version bump and ginkgo /v2/ into separate PRs? What about bumping to latest golang version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a bump to the current 1.19 in #28