Updating to ginkgo v2 #18
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| package cfhttp_test | ||
|
|
||
| import ( | ||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
|
|
||
| "testing" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,18 @@ | ||
| module code.cloudfoundry.org/cfhttp | ||
|
|
||
| go 1.17 | ||
|
|
||
| require ( | ||
| github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d | ||
| github.com/onsi/ginkgo/v2 v2.1.3 | ||
| github.com/onsi/gomega v1.18.1 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/golang/protobuf v1.5.2 // indirect | ||
| golang.org/x/net v0.0.0-20220225172249-27dd8689420f // indirect | ||
|
There was a problem hiding this comment. Do we really need this import? The version used seems to be not official. Most probably because the PR is from the beginning of March 2022 and there haven't been official release of the library. Perhaps it is worth updating the PR (go modules) with latest dependencies used. There was a problem hiding this comment. I have added a bump to latest direct and indirect dependencies in #28 |
||
| golang.org/x/sys v0.0.0-20220227234510-4e6760a101f9 // indirect | ||
|
There was a problem hiding this comment. Do we really need this import? The version used seems to be not official. Most probably because the PR is from the beginning of March 2022 and there haven't been official release of the library. Perhaps it is worth updating the PR (go modules) with latest dependencies used. There was a problem hiding this comment. I have added a bump to latest direct and indirect dependencies in #28 |
||
| golang.org/x/text v0.3.7 // indirect | ||
| google.golang.org/protobuf v1.26.0 // indirect | ||
| gopkg.in/yaml.v2 v2.4.0 // indirect | ||
| ) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| package handlers_test | ||
|
|
||
| import ( | ||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
|
|
||
| "testing" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,17 @@ | ||
| module code.cloudfoundry.org/cfhttp/v2 | ||
|
|
||
| go 1.17 | ||
|
|
||
| require ( | ||
| github.com/onsi/ginkgo/v2 v2.1.3 | ||
| github.com/onsi/gomega v1.18.1 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/golang/protobuf v1.5.2 // indirect | ||
| golang.org/x/net v0.0.0-20220225172249-27dd8689420f // indirect | ||
| golang.org/x/sys v0.0.0-20211216021012-1d35b9e2eb4e // indirect | ||
| golang.org/x/text v0.3.7 // indirect | ||
| google.golang.org/protobuf v1.26.0 // indirect | ||
| gopkg.in/yaml.v2 v2.4.0 // indirect | ||
| ) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it is worth mentioning that the PR bumps the golang version as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW: What do you think if we separate the golang version bump and ginkgo /v2/ into separate PRs? What about bumping to latest golang version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a bump to the current 1.19 in #28