v7: Update ginkgo version to v2 (#2808)

Update CLI to use ginkgo v2 for V7

* Add user agent info for plugin api calls
* Newer lager was needed with newer diego-ssh
* Replace depracted ginkgo calls with non deprecated calls
* Remove ACK_GINKGO_RC
* Desperate attempt at resolving output issue by using serial decorator and using non deprecated pty
* Turn off  Gingkno v2 parallel mode
* Adjust integration tests to use ginkgo v2
* Add Byte to lograte, disk and memory regexes used by int tests
---------

Co-authored-by: M. Oleske <moleske@pivotal.io>
Co-authored-by: Al Berez <al.berez@broadcom.com>
Co-authored-by: Cristhian Peña <ccjaimes@users.noreply.github.com>
Co-authored-by: Marc Paquette <marc.paquette@broadcom.com>

.github/win/integrations/integration-tests.ps1

@@ -49,7 +49,7 @@ $Env:RUN_ID=(openssl rand -hex 16)
 $Env:GOFLAGS = "-mod=mod"
 
 if ((Get-Command "ginkgo" -ErrorAction SilentlyContinue) -eq $null) {
-	go install -v github.com/onsi/ginkgo/ginkgo@v1.16.4
+  go install -v github.com/onsi/ginkgo/v2/ginkgo@latest
 }
 
 $CF_INT_NAME=(Get-Content $pwd\metadata.json -Raw| Out-String | ConvertFrom-Json).name.trim()

.github/workflows/tests-integration-reusable.yml

@@ -112,7 +112,7 @@ jobs:
           sleep 30
         done
         cat metadata.json | jq -r '.name'
-
+    
     - name: Install Tools
       run: |
         if [[ ${{ inputs.os }} =~ "windows" ]]
@@ -240,7 +240,7 @@ jobs:
 
         make build
 
-        go install github.com/onsi/ginkgo/ginkgo@v1.16.4
+        go install github.com/onsi/ginkgo/v2/ginkgo
 
         export CF_PASSWORD=${CF_INT_PASSWORD}
         cf api ${CF_INT_API} --skip-ssl-validation
@@ -270,7 +270,7 @@ jobs:
 
         make build
 
-        go install github.com/onsi/ginkgo/ginkgo@v1.16.4
+        go install github.com/onsi/ginkgo/v2/ginkgo
 
         export CF_PASSWORD=${CF_INT_PASSWORD}
         cf api ${CF_INT_API} --skip-ssl-validation

.github/workflows/tests-unit.yml

@@ -67,13 +67,11 @@ jobs:
 
     - name: Set Up Test
       run: |
-        go install github.com/onsi/ginkgo/ginkgo@v1.16.4
+        go install github.com/onsi/ginkgo/v2/ginkgo
         go install github.com/onsi/gomega/matchers
 
     - name: Run Units
       run: make units
-      env:
-        ACK_GINKGO_RC: true
 
   units-windows:
     name: Units Windows
@@ -100,16 +98,14 @@ jobs:
 
     - name: Set up Test
       run: |
-        go install github.com/onsi/ginkgo/ginkgo@v1.16.4
+        go install github.com/onsi/ginkgo/v2/ginkgo
         go install github.com/onsi/gomega/matchers
 
     - name: Get build-time dependencies
       run: |
         choco install --no-progress --limit-output -y make
 
     - name: Run Windows Units
-      env:
-        ACK_GINKGO_RC: true
       run: |
         Get-Command make
         Get-Item Makefile

Makefile

@@ -16,13 +16,13 @@ REQUIRED_FOR_STATIC_BINARY =-a -tags "netgo" -installsuffix netgo
 GOSRC = $(shell find . -name "*.go" ! -name "*test.go" ! -name "*fake*" ! -path "./integration/*")
 UNAME_S := $(shell uname -s)
 
-SLOW_SPEC_THRESHOLD=120
+POLL_PROGRESS_THRESHOLD=120s
 
-GINKGO_FLAGS ?= -r -randomizeAllSpecs -requireSuite
-GINKGO_INT_FLAGS = $(GINKGO_FLAGS) -slowSpecThreshold $(SLOW_SPEC_THRESHOLD)
+GINKGO_FLAGS ?= -r -randomize-all -require-suite
+GINKGO_INT_FLAGS = $(GINKGO_FLAGS) --poll-progress-after $(POLL_PROGRESS_THRESHOLD)
 ginkgo_int = ginkgo $(GINKGO_INT_FLAGS)
 
-GINKGO_UNITS_FLAGS = $(GINKGO_FLAGS) -randomizeSuites -p
+GINKGO_UNITS_FLAGS = $(GINKGO_FLAGS) -randomize-suites
 ginkgo_units = ginkgo $(GINKGO_UNITS_FLAGS)
 GOFLAGS := -mod=mod
 
@@ -138,9 +138,9 @@ integration-full-tests: integration-tests-full
 integration-tests-full: build integration-cleanup integration-isolated integration-push integration-experimental integration-plugin integration-global integration-selfcontained ## Run all isolated, push, experimental, plugin, selfcontained, and global integration tests
 
 integration-tests-full-ci: integration-cleanup
-	$(ginkgo_int) -nodes $(NODES)  -flakeAttempts $(FLAKE_ATTEMPTS) \
+	$(ginkgo_int) -nodes $(NODES)  -flake-attempts $(FLAKE_ATTEMPTS) \
 		integration/shared/isolated integration/v7/isolated integration/shared/plugin integration/shared/experimental integration/v7/experimental integration/v7/push
-	$(ginkgo_int) -flakeAttempts $(FLAKE_ATTEMPTS) integration/shared/global integration/v7/global
+	$(ginkgo_int) -flake-attempts $(FLAKE_ATTEMPTS) integration/shared/global integration/v7/global
 
 lint: custom-lint ## Runs all linters and formatters
 	@echo "Running linters..."
@@ -200,22 +200,22 @@ test: units ## (synonym for units)
 units: units-full ## (synonym for units-full)
 
 units-plugin:
-	CF_HOME=$(CURDIR)/fixtures $(ginkgo_units) -nodes 1 -flakeAttempts 2 -skipPackage integration ./**/plugin* ./plugin
+	CF_HOME=$(CURDIR)/fixtures $(ginkgo_units) -nodes 1 -flake-attempts 2 -skip-package integration ./**/plugin* ./plugin
 
 ifeq ($(OS),Windows_NT)
 units-non-plugin:
 	@rm -f $(wildcard fixtures/plugins/*.exe)
 	@ginkgo version
 	CF_HOME=$(CURDIR)/fixtures CF_USERNAME="" CF_PASSWORD="" $(ginkgo_units) \
-		-skipPackage integration,cf\ssh,plugin,cf\actors\plugin,cf\commands\plugin,cf\actors\plugin,util\randomword
-	CF_HOME=$(CURDIR)/fixtures $(ginkgo_units) -flakeAttempts 3 cf/ssh
+		-skip-package integration,cf\ssh,plugin,cf\actors\plugin,cf\commands\plugin,cf\actors\plugin,util\randomword
+	CF_HOME=$(CURDIR)/fixtures $(ginkgo_units) -flake-attempts 3 cf/ssh
 else
 units-non-plugin:
 	@rm -f $(wildcard fixtures/plugins/*.exe)
 	@ginkgo version
 	CF_HOME=$(CURDIR)/fixtures CF_USERNAME="" CF_PASSWORD="" $(ginkgo_units) \
-		-skipPackage integration,cf/ssh,plugin,cf/actors/plugin,cf/commands/plugin,cf/actors/plugin,util/randomword
-	CF_HOME=$(CURDIR)/fixtures $(ginkgo_units) -flakeAttempts 3 cf/ssh
+		-skip-package integration,cf/ssh,plugin,cf/actors/plugin,cf/commands/plugin,cf/actors/plugin,util/randomword
+	CF_HOME=$(CURDIR)/fixtures $(ginkgo_units) -flake-attempts 3 cf/ssh
 endif
 
 units-full: build units-plugin units-non-plugin

actor/actionerror/actionerror_suite_test.go

@@ -3,7 +3,7 @@ package actionerror_test
 import (
 	"testing"
 
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/actionerror/duplicate_service_error_test.go

@@ -2,7 +2,7 @@ package actionerror_test
 
 import (
 	"code.cloudfoundry.org/cli/actor/actionerror"
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/actionerror/duplicate_service_plan_error_test.go

@@ -2,7 +2,7 @@ package actionerror_test
 
 import (
 	"code.cloudfoundry.org/cli/actor/actionerror"
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/actionerror/enrich_api_errors_test.go

@@ -7,7 +7,7 @@ import (
 
 	"code.cloudfoundry.org/cli/actor/actionerror"
 
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/actionerror/package_not_found_in_app_error_test.go

@@ -2,7 +2,7 @@ package actionerror_test
 
 import (
 	"code.cloudfoundry.org/cli/actor/actionerror"
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/actionerror/route_not_found_error_test.go

@@ -2,7 +2,7 @@ package actionerror_test
 
 import (
 	"code.cloudfoundry.org/cli/actor/actionerror"
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/actionerror/service_not_found_error_test.go

@@ -2,7 +2,7 @@ package actionerror_test
 
 import (
 	"code.cloudfoundry.org/cli/actor/actionerror"
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/actionerror/service_plan_not_found_error_test.go

@@ -4,7 +4,7 @@ import (
 	"fmt"
 
 	"code.cloudfoundry.org/cli/actor/actionerror"
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/actionerror/space_not_found_error_test.go

@@ -2,7 +2,7 @@ package actionerror_test
 
 import (
 	"code.cloudfoundry.org/cli/actor/actionerror"
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/cfnetworkingaction/cfnetworkingaction_suite_test.go

@@ -1,7 +1,7 @@
 package cfnetworkingaction_test
 
 import (
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 
 	"testing"

actor/cfnetworkingaction/policy_test.go

@@ -13,7 +13,7 @@ import (
 	"code.cloudfoundry.org/cli/actor/actionerror"
 	. "code.cloudfoundry.org/cli/actor/cfnetworkingaction"
 	"code.cloudfoundry.org/cli/actor/cfnetworkingaction/cfnetworkingactionfakes"
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/pluginaction/checksum_test.go

@@ -6,7 +6,7 @@ import (
 
 	. "code.cloudfoundry.org/cli/actor/pluginaction"
 	"code.cloudfoundry.org/cli/actor/pluginaction/pluginactionfakes"
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/pluginaction/install_test.go

@@ -13,7 +13,7 @@ import (
 	"code.cloudfoundry.org/cli/api/plugin/pluginfakes"
 	"code.cloudfoundry.org/cli/util/configv3"
 	"code.cloudfoundry.org/cli/util/generic"
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/pluginaction/install_unix_test.go

@@ -11,7 +11,7 @@ import (
 	. "code.cloudfoundry.org/cli/actor/pluginaction"
 	"code.cloudfoundry.org/cli/actor/pluginaction/pluginactionfakes"
 	"code.cloudfoundry.org/cli/util/configv3"
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/pluginaction/install_windows_test.go

@@ -9,7 +9,7 @@ import (
 
 	. "code.cloudfoundry.org/cli/actor/pluginaction"
 	"code.cloudfoundry.org/cli/actor/pluginaction/pluginactionfakes"
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/pluginaction/list_test.go

@@ -8,7 +8,7 @@ import (
 	"code.cloudfoundry.org/cli/actor/pluginaction/pluginactionfakes"
 	"code.cloudfoundry.org/cli/api/plugin"
 	"code.cloudfoundry.org/cli/util/configv3"
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/pluginaction/plugin_info_test.go

@@ -8,7 +8,7 @@ import (
 	"code.cloudfoundry.org/cli/actor/pluginaction/pluginactionfakes"
 	"code.cloudfoundry.org/cli/api/plugin"
 	"code.cloudfoundry.org/cli/util/configv3"
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/pluginaction/plugin_repository_test.go

@@ -9,7 +9,7 @@ import (
 	"code.cloudfoundry.org/cli/actor/pluginaction/pluginactionfakes"
 	"code.cloudfoundry.org/cli/api/plugin"
 	"code.cloudfoundry.org/cli/util/configv3"
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/pluginaction/pluginaction_suite_test.go

@@ -1,7 +1,7 @@
 package pluginaction_test
 
 import (
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 
 	"testing"

actor/pluginaction/uninstall_test.go

@@ -11,7 +11,7 @@ import (
 	. "code.cloudfoundry.org/cli/actor/pluginaction"
 	"code.cloudfoundry.org/cli/actor/pluginaction/pluginactionfakes"
 	"code.cloudfoundry.org/cli/util/configv3"
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/pushaction/actualize_test.go

@@ -11,7 +11,7 @@ import (
 	"code.cloudfoundry.org/cli/actor/v3action"
 	"code.cloudfoundry.org/cli/api/cloudcontroller/ccerror"
 
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 	. "github.com/onsi/gomega/gstruct"
 )

actor/pushaction/application_config_test.go

@@ -17,7 +17,7 @@ import (
 	"code.cloudfoundry.org/cli/api/cloudcontroller/ccv2/constant"
 	"code.cloudfoundry.org/cli/types"
 	"code.cloudfoundry.org/cli/util/manifest"
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 	. "github.com/onsi/gomega/gstruct"
 )

actor/pushaction/application_test.go

@@ -12,8 +12,7 @@ import (
 	"code.cloudfoundry.org/cli/api/cloudcontroller/ccv3/constant"
 	"code.cloudfoundry.org/cli/types"
 
-	. "github.com/onsi/ginkgo"
-	. "github.com/onsi/ginkgo/extensions/table"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 	. "github.com/onsi/gomega/gstruct"
 )

actor/pushaction/apply_test.go

@@ -11,7 +11,7 @@ import (
 	"code.cloudfoundry.org/cli/actor/v2action"
 	"code.cloudfoundry.org/cli/api/cloudcontroller/ccerror"
 	"code.cloudfoundry.org/cli/cf/util/testhelpers/matchers"
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/pushaction/command_line_settings_test.go

@@ -4,8 +4,7 @@ import (
 	. "code.cloudfoundry.org/cli/actor/pushaction"
 	"code.cloudfoundry.org/cli/types"
 	"code.cloudfoundry.org/cli/util/manifest"
-	. "github.com/onsi/ginkgo"
-	. "github.com/onsi/ginkgo/extensions/table"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/pushaction/command_line_settings_unix_test.go

@@ -7,8 +7,7 @@ import (
 	. "code.cloudfoundry.org/cli/actor/pushaction"
 	"code.cloudfoundry.org/cli/util/manifest"
 
-	. "github.com/onsi/ginkgo"
-	. "github.com/onsi/ginkgo/extensions/table"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/pushaction/command_line_settings_windows_test.go

@@ -7,8 +7,8 @@ import (
 	. "code.cloudfoundry.org/cli/actor/pushaction"
 	"code.cloudfoundry.org/cli/util/manifest"
 
-	. "github.com/onsi/ginkgo"
-	. "github.com/onsi/ginkgo/extensions/table"
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/ginkgo/v2/extensions/table"
 	. "github.com/onsi/gomega"
 )
 

actor/pushaction/domain_test.go

@@ -8,7 +8,7 @@ import (
 	"code.cloudfoundry.org/cli/actor/pushaction/pushactionfakes"
 	"code.cloudfoundry.org/cli/actor/v2action"
 
-	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
 

actor/pushaction/merge_and_validate_settings_and_manifest_test.go

@@ -8,8 +8,7 @@ import (
 	. "code.cloudfoundry.org/cli/actor/pushaction"
 	"code.cloudfoundry.org/cli/types"
 	"code.cloudfoundry.org/cli/util/manifest"
-	. "github.com/onsi/ginkgo"
-	. "github.com/onsi/ginkgo/extensions/table"
+	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )