v7: Update ginkgo version to v2 #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add user agent info for plugin api calls - Newer lager was needed with newer diego-ssh * Replace depracted ginkgo calls with non deprecated calls * Remove ACK_GINKGO_RC * Desperate attempt at resolving output issue by using serial decorator and using non deprecated pty * Turn off Gingkno v2 parallel mode * Adjust integration tests to use ginkgo v2 * Add Byte to lograte, disk and memory regexes used by int tests --------- Co-authored-by: M. Oleske <moleske@pivotal.io> Co-authored-by: Al Berez <al.berez@broadcom.com> Co-authored-by: Cristhian Peña <ccjaimes@users.noreply.github.com> Co-authored-by: Marc Paquette <marc.paquette@broadcom.com>
a-b
reviewed
Mar 23, 2024
| @@ -1,6 +1,6 @@ | |||
| name: "Tests: Integration" | |||
|
|
|||
| run-name: "Integration [${{ github.event.workflow_run.head_branch }}]: ${{ github.event.workflow_run.head_commit.message }}" | |||
| # run-name: "Integration [${{ github.event.workflow_run.head_branch }}]: ${{ github.event.workflow_run.head_commit.message }}" | |||
There was a problem hiding this comment.
Why did you comment out this code? At least It seems inconsistent with the main and V8 code.
a-b
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the CF CLI! Please read the following:
If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
Where this PR should be backported?
Description of the Change
CLI was using ginkgo version v1 which is outdated for a while now. This change updates the ginkgo version to v2.
Why Is This PR Valuable?
Updates the ginkgo version so that there is on going support for this dependency.
Applicable Issues
None
How Urgent Is The Change?
Not urgent
Other Relevant Parties
Who else is affected by the change?