-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WONTFIX]: Platform Engineer can limit memory used during staging using stagingRequirements.memoryMB
#2654
Comments
I left a comment with some thoughts on implementation the disk story that also apply to this one: |
[#2654] Reorganized the staging resource configuration under its own struct to better capture the intent of the fields. Co-authored-by: Dave Walter <walterda@vmware.com>
[#2654] Reorganized the staging resource configuration under its own struct to better capture the intent of the fields. Co-authored-by: Dave Walter <walterda@vmware.com>
stagingRequirements.memoryMB
stagingRequirements.memoryMB
~
stagingRequirements.memoryMB
~stagingRequirements.memoryMB
~~
stagingRequirements.memoryMB
~~stagingRequirements.memoryMB
This was effectively undone by #2685. This feature was originally oriented around setting limits. After some discussion on a Slack thread and a Github issue we decided to undo that. The original CF installation properties were interpreted as a minimum resource request versus a hard limit so we made this value optional (no requests) and allow operators to specify it if they want to set that minimum. CF for VMs uses a quota system to set operator-specified limits -- so that might be something worth exploring if we want to do this in the future. Given that we don't want to do this right now and that the implementation/UX should likely look very different, I am going to close this issue as "wontfix". |
Blockers/Dependencies
No response
Background
As a Platform Engineer
I want to be able to set a memory limit for staging apps
So that I have more predictable utilization of my platform
Acceptance Criteria
GIVEN I have configured the
stagingRequirements.memoryMB
Helm valueWHEN I
cf push
an appTHEN I see that there is a memory resource limit on the kpack
Image
/Pod
performing the build corresponding with the value I setDev Notes
CFApp
/CFBuild
level since apps will have varying requirements here.The text was updated successfully, but these errors were encountered: