Do not configure staging resources by default #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davewalter
reviewed
Jul 13, 2023
kpack-image-builder/controllers/buildworkload_controller_test.go
Outdated
Show resolved
Hide resolved
Instead, only set resource requests when the configuration is present. We plan to handle resource limits separately and will not set those directly on the pods. Co-authored-by: Dave Walter <walterda@vmware.com>
davewalter
approved these changes
Jul 13, 2023
tcdowney
approved these changes
Jul 13, 2023
This was referenced Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2682
What is this change about?
Revert the changes that set resource limits on the kpack build pods, instead opting to configure requests.
Does this PR introduce a breaking change?
No, only the internal controller configmap interface is updated.
Acceptance Steps
See issue.
Tag your pair, your PM, and/or team
paired w/ @davewalter
Open Questions
Added a note to the refactor issue dev notes about the difficulty we had reasoning about the exercising the different configuration options in the controller test suite.