[Chore]: Implement real readyz check for controllers #861
Comments
kieron-dev
pushed a commit
that referenced
this issue
Mar 25, 2022
And wait for the deployment to be ready in deploy-on-kind script Issue: #861
kieron-dev
pushed a commit
that referenced
this issue
Mar 25, 2022
And wait for the deployment to be ready in deploy-on-kind script Issue: #861
kieron-dev
pushed a commit
that referenced
this issue
Mar 25, 2022
And wait for the deployment to be ready in deploy-on-kind script Issue: #861
kieron-dev
pushed a commit
that referenced
this issue
Mar 25, 2022
And wait for the deployment to be ready in deploy-on-kind script Issue: #861
kieron-dev
pushed a commit
that referenced
this issue
Mar 25, 2022
And wait for the deployment to be ready in deploy-on-kind script Issue: #861
georgethebeatle
pushed a commit
that referenced
this issue
Mar 25, 2022
And wait for the deployment to be ready in deploy-on-kind script Issue: #861
|
Closing this issue. It was completed by PR #862. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
We are seeing a lot of failures in e2es where the beforeSuite attempts to create a cfdomain, but the controllers webhook for that isn't ready yet.
Instead of using an eventually, or waiting for a successful cfdomain creation in the setup script, we should correctly implement the /readyz endpoint so that it only returns true when all webhook services are available.
Action to take
Implement /readyz in the controllers binary so that it checks all webhook services are available.
Make the deploy-on-kind script wait until the controllers deployment is ready.
Impact
E2es won't start until the controllers deployment is fully started, and so will flake less.
Dev Notes
controller-runtime has helpers built-in for this since 0.10. See kubernetes-sigs/controller-runtime#1588
The text was updated successfully, but these errors were encountered: