Use the webhook server StartedChecker() for /readyz #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieron-dev
force-pushed
the
issues/861-readyz-check
branch
2 times, most recently
from
5c5ae65
to
b17d414
Compare
georgethebeatle
approved these changes
Mar 25, 2022
kieron-dev
force-pushed
the
issues/861-readyz-check
branch
from
b17d414
to
cc45ca6
Compare
And wait for the deployment to be ready in deploy-on-kind script Issue: #861
kieron-dev
force-pushed
the
issues/861-readyz-check
branch
from
cc45ca6
to
f4dc9ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#861
What is this change about?
We are currently using the default /readyz check which returns true immediately. controller-runtime provides a built-in ready check for webhook servers, so this PR uses that instead.
This also adds a wait for the deployment to be ready in the deploy-on-kind script, ensuring all webhooks and controllers are ready.
This should remove the flakes we've seen in e2es where creating the default cfdomain in the before suite fails because the webhook isn't ready yet.
Does this PR introduce a breaking change?
No
Acceptance Steps
deploy-on-kind should wait a while for the controllers deployment to be ready. And after that we should see no errors about webhooks refusing requests.