adding API endpoints to Terminate a process instances (cf restart-app… #3368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsteg
force-pushed
the
instanceRestart
branch
7 times, most recently
from
2da4d9f
to
73f556a
Compare
georgethebeatle
requested changes
Jul 8, 2024
marsteg
added a commit
to marsteg/korifi
that referenced
this pull request
Jul 9, 2024
marsteg
force-pushed
the
instanceRestart
branch
2 times, most recently
from
7ea8f48
to
b2c84c1
Compare
|
i've updated the PR now. Please have a look, when you have the time. Best Regards, |
marsteg
force-pushed
the
instanceRestart
branch
2 times, most recently
from
ce8cdc3
to
3df82ee
Compare
georgethebeatle
requested changes
Jul 11, 2024
marsteg
force-pushed
the
instanceRestart
branch
2 times, most recently
from
22a733d
to
fbe07fe
Compare
danail-branekov
requested changes
Jul 17, 2024
|
Mended PR according to the comments. Sorry for the leftovers and many required turnarounds... |
danail-branekov
previously approved these changes
Jul 17, 2024
georgethebeatle
previously approved these changes
Jul 17, 2024
auto-merge was automatically disabled
July 17, 2024 19:07
Head branch was pushed to by a user without write access
marsteg
dismissed stale reviews from georgethebeatle and danail-branekov
via
a386050
danail-branekov
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3350
What is this change about?
Adding cf restart-app-instance API endpoints
Does this PR introduce a breaking change?
Not that I know of.
Acceptance Steps
in the cf cli, the command:
cf restart-app-instance test-app 3 --process web -v
works
Tag your pair, your PM, and/or team
@danail-branekov @georgethebeatle