-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding API endpoints to Terminate a process instances (cf restart-app… #3368
Conversation
2da4d9f
to
73f556a
Compare
7ea8f48
to
b2c84c1
Compare
i've updated the PR now. Please have a look, when you have the time. Best Regards, |
ce8cdc3
to
3df82ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some more comments inline
22a733d
to
fbe07fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few forgotten focused tests. I have also put some other minor comments.
Other than that looks fine
Mended PR according to the comments. Sorry for the leftovers and many required turnarounds... |
Head branch was pushed to by a user without write access
a386050
Is there a related GitHub Issue?
#3350
What is this change about?
Adding cf restart-app-instance API endpoints
Does this PR introduce a breaking change?
Not that I know of.
Acceptance Steps
in the cf cli, the command:
cf restart-app-instance test-app 3 --process web -v
works
Tag your pair, your PM, and/or team
@danail-branekov @georgethebeatle