Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle deploy from folder with executables #3468

Closed
richard-cox opened this issue Apr 4, 2019 · 1 comment
Closed

Handle deploy from folder with executables #3468

richard-cox opened this issue Apr 4, 2019 · 1 comment
Labels
bug

Comments

@richard-cox
Copy link
Contributor

  • the app from cf-quick-app requires executable rights on it's app.sh, which it has
  • when using deploy with file upload the permission gets changed (to 0644, which makes sense)
  • app cannot start due to file permission error
  • we could
    ... try and detect the permissions client side and update server side (risky)?
    ... try and detect the permissions client side and warn user if executable scripts are found?
    ... try to determine the file that will be executed (eek) and fail deploy early?
@richard-cox richard-cox added the bug label Apr 4, 2019
@richard-cox richard-cox mentioned this issue Apr 4, 2019
Merged
KlapTrap pushed a commit that referenced this issue Apr 8, 2019
@richard-cox @KlapTrap
Fix Gitlab deploy step (#3469)
ead1146 
- fixed
  - exception thrown when failing to parse error
  - missing project avatar image
- blocked on #3461
- see also #3468
@richard-cox
Copy link
Contributor Author

dupe of #3192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richard-cox