Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base step to application creation. #3461

Merged
merged 13 commits into from
Apr 5, 2019
Merged

Conversation

KlapTrap
Copy link
Contributor

@KlapTrap KlapTrap commented Apr 1, 2019

Remove the deploy application from the application wall and instead have a single create button that takes the user to a page where they can select their desired creation type.

@cfdreddbot
Copy link

✅ Hey KlapTrap! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #3461 into v2-master will increase coverage by 0.17%.
The diff coverage is 82.05%.

@@              Coverage Diff              @@
##           v2-master    #3461      +/-   ##
=============================================
+ Coverage      51.44%   51.61%   +0.17%     
=============================================
  Files            697      701       +4     
  Lines          19418    19505      +87     
  Branches        3428     3455      +27     
=============================================
+ Hits            9989    10068      +79     
- Misses          9429     9437       +8

@richard-cox
Copy link
Contributor

Haven't seen the updated code yet but tested each type, everything worked fine except..
gitlab -

  • select a valid project - missing project icon (shows missing image graphic)
  • select an invalid project - exception thrown
core.js:15714 ERROR TypeError: Cannot read property 'logger' of undefined
   at parseHttpPipeError (utils.service.ts:243)
   at createFailedGithubRequestMessage (deploy-app.effects.ts:37)
   at CatchSubscriber.selector (deploy-app.effects.ts:105)

deploy from folder

  • when deploying quick app instance crashes with 1bash: ./app.sh: Permission denied
  • we may be clearing file permissions again

These, especially the second, could already be an issue in master

@KlapTrap
Copy link
Contributor Author

KlapTrap commented Apr 3, 2019

I haven't fundamentally changed how the deploy works so I would imagine those are issues on master too.

@richard-cox richard-cox merged commit 92af8fd into v2-master Apr 5, 2019
@richard-cox richard-cox deleted the create-app-base-step branch April 5, 2019 08:56
KlapTrap pushed a commit that referenced this pull request Apr 8, 2019
- fixed
  - exception thrown when failing to parse error
  - missing project avatar image
- blocked on #3461
- see also #3468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants