Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api Effect: Don't validate when there are no results #2683

Closed
wants to merge 2 commits into from

Conversation

KlapTrap
Copy link
Contributor

Fixes #2682

Although this fixes the issue I think there may be issues within the validation.

@richard-cox why does the validation, when given an empty array for an entity list, not fill out the page of the pagination?

Example

Api Response

{
...
resources: []
total_pages: 1,
total_results: 1
}

What ends up in the store pagination section:

{
...
ids: {}
...
}

Expected:

{
...
ids: { 1: [] }
...
}

@cfdreddbot
Copy link

Hey KlapTrap!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@KlapTrap
Copy link
Contributor Author

Created #2684 to track the issue.

@richard-cox
Copy link
Contributor

Created #2685, that should cover validation cases via both the api effect and entity/pagination services

@KlapTrap KlapTrap closed this Jul 18, 2018
@nwmac nwmac deleted the page-undefined branch June 12, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Application shows empty page
3 participants