Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure lists with no entities populate pagination section correctly #2685

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

richard-cox
Copy link
Contributor

- ids: { } => ids: { 1: [] }
- think this is a regression following the removal of partial entities
- Fixes #2682, #2684
@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Jul 18, 2018

Codecov Report

Merging #2685 into v2-master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           v2-master   #2685   +/-   ##
=========================================
  Coverage       69.9%   69.9%           
=========================================
  Files            598     598           
  Lines          25408   25408           
  Branches        5750    5750           
=========================================
  Hits           17761   17761           
  Misses          7647    7647

@KlapTrap KlapTrap merged commit 5e29bd5 into v2-master Jul 18, 2018
@nwmac nwmac deleted the fix-validation-no-results branch June 12, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants