Fix CF-Level Metrics permissions check #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey nwmac! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3348 +/- ##
=============================================
- Coverage 70.99% 70.96% -0.03%
=============================================
Files 661 661
Lines 29170 29188 +18
Branches 6670 6668 -2
=============================================
+ Hits 20708 20714 +6
- Misses 8462 8474 +12 |
|
@richard-cox I checked the cells API - looks like we whitelist specific metrics - so I think that is okay. This is ready to merge |
- Cell metrics used incorrect endpoint (regression) - This whitelists certain metrics that a non-cf admin can use - Non-cf admins can see all cell details... except apps in cells - Also fixed issue where cell list used old action
richard-cox
approved these changes
Jan 18, 2019
KlapTrap
pushed a commit
that referenced
this pull request
Jan 29, 2019
* v2-master: (34 commits) v2/v3 api docs updates Fix create-services script used to set CF up for E2E tests Only prevent copy & paste in confirm dialog for production Fix for bug causing intermittment E2E Test failures on org tests (#3366) Allow e2e createService 3 attempts at creating service Weekly updaye 18 January (#3365) Change log for 2.3.0 (#3364) Ensure the loading indicator and the refresh button animated at the correct time. (#3363) Fix fetching of stats in app wall for some cases when list is maxed (#3360) Fix CF-Level Metrics permissions check (#3348) About Page Title customization support (#3356) Revert loading indicator fixes Fix app state to allow start action for offline while updating (#3350) Fix display of percent tooltip on metrics chart (#3361) Ensure the SCM type is included in store keys (#3353) Manually make the date selector date a moment object (#3352) Fix filter panel size on services and marketplace pages (#3358) Tidy up org spce reducer logic Remove full stops from empty list messages - fixes #3340 Fix search by space name in manage users space roles table - fixes #3329 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes these issues: