Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix precision in display of percent tooltip on metrics chart #3361

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Jan 17, 2019

Fixes #3336 - Metrics Charts: CPU usage tooltip should round value

@nwmac nwmac self-assigned this Jan 17, 2019
@cfdreddbot
Copy link

✅ Hey nwmac! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #3361 into v2-master will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##           v2-master    #3361      +/-   ##
=============================================
+ Coverage      70.97%   70.97%   +<.01%     
=============================================
  Files            661      661              
  Lines          29174    29182       +8     
  Branches        6665     6667       +2     
=============================================
+ Hits           20707    20713       +6     
- Misses          8467     8469       +2

@richard-cox richard-cox merged commit 1d3f075 into v2-master Jan 17, 2019
@richard-cox richard-cox deleted the fix-metrics-chart-cpu branch January 17, 2019 16:11
KlapTrap pushed a commit that referenced this pull request Jan 29, 2019
* v2-master: (34 commits)
  v2/v3 api docs updates
  Fix create-services script used to set CF up for E2E tests
  Only prevent copy & paste in confirm dialog for production
  Fix for bug causing intermittment E2E Test failures on org tests (#3366)
  Allow e2e createService 3 attempts at creating service
  Weekly updaye 18 January (#3365)
  Change log for 2.3.0 (#3364)
  Ensure the loading indicator and the refresh button animated at the correct time. (#3363)
  Fix fetching of stats in app wall for some cases when list is maxed (#3360)
  Fix CF-Level Metrics permissions check (#3348)
  About Page Title customization support (#3356)
  Revert loading indicator fixes
  Fix app state to allow start action for offline while updating (#3350)
  Fix display of percent tooltip on metrics chart (#3361)
  Ensure the SCM type is included in store keys (#3353)
  Manually make the date selector date a moment object (#3352)
  Fix filter panel size on services and marketplace pages (#3358)
  Tidy up org spce reducer logic
  Remove full stops from empty list messages - fixes #3340
  Fix search by space name in manage users space roles table - fixes #3329
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants