Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugins): add helm diff to status #890

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(plugins): add helm diff to status #890

wants to merge 3 commits into from

Conversation

gciezkowski-acc
Copy link
Contributor

@gciezkowski-acc gciezkowski-acc commented Feb 7, 2025 •
edited
Loading

Description

Add diff field to Helm Release Status.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

I updated the current E2E test.

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@gciezkowski-acc gciezkowski-acc force-pushed the feat/858_helm_diff_is_added_to_status branch from fea2154 to 5335562 Compare February 7, 2025 11:00
@github-actions github-actions bot added feature core-apis helm-charts documentation Improvements or additions to documentation labels Feb 7, 2025
@gciezkowski-acc gciezkowski-acc force-pushed the feat/858_helm_diff_is_added_to_status branch from ae14ff7 to 60ba09e Compare February 7, 2025 11:37
@gciezkowski-acc gciezkowski-acc marked this pull request as ready for review February 7, 2025 11:48
@gciezkowski-acc gciezkowski-acc requested a review from a team as a code owner February 7, 2025 11:48
@gciezkowski-acc gciezkowski-acc force-pushed the feat/858_helm_diff_is_added_to_status branch from 2d41edf to 8c357cc Compare February 11, 2025 16:07
@gciezkowski-acc gciezkowski-acc force-pushed the feat/858_helm_diff_is_added_to_status branch from 8c357cc to b967ae9 Compare February 11, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvoGoman IvoGoman Awaiting requested review from IvoGoman

@uwe-mayer uwe-mayer Awaiting requested review from uwe-mayer

@abhijith-darshan abhijith-darshan Awaiting requested review from abhijith-darshan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
core-apis documentation Improvements or additions to documentation feature helm-charts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gciezkowski-acc @cloud-operator